Getting rid of GetDefaultProfile & fixing multi user issues with accessibility

ash/accessibility_delegate.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_ACCESSIBILITY_DELEGATE_H_
 #define ASH_ACCESSIBILITY_DELEGATE_H_
 
 #include "ash/ash_export.h"
 #include "ash/magnifier/magnifier_constants.h"
 #include "base/time/time.h"
@@ skipping 45 matching lines @@
 
   // Returns ture if Large Cursor is enabled or not.
   virtual bool IsLargeCursorEnabled() const = 0;
 
   // Invoked to enable autoclick.
   virtual void SetAutoclickEnabled(bool enabled) = 0;
 
   // Returns if autoclick is enabled or not.
   virtual bool IsAutoclickEnabled() const = 0;
 
-  // Returns true if the user wants to show accesibility menu even when all the
-  // accessibility features are disabled.
-  virtual bool ShouldAlwaysShowAccessibilityMenu() const = 0;
+  // Returns true if the user wants to show accessibility menu.

[dmazzoni, 2013/12/13 16:15:07]

I think it's misleading to say "if the user wants..."

Previously this function only returned true if the user had chosen to always
show the accessibility menu by a preference. It looks like now you're using this
function to compute if it should be shown for other reason.

So I'd comment "Returns true if the accessibility menu should be shown, which
may be because of an explicit user preference or because one of the logged-in
users has an accessibility setting on."

[Mr4D (OOO till 08-26), 2013/12/13 17:21:13]

Done.

+  virtual bool ShouldShowAccessibilityMenu() const = 0;
 
   // Cancel all current and queued speech immediately.
   virtual void SilenceSpokenFeedback() const = 0;
 
   // Saves the zoom scale of the full screen magnifier.
   virtual void SaveScreenMagnifierScale(double scale) = 0;
 
   // Gets a saved value of the zoom scale of full screen magnifier. If a value
   // is not saved, return a negative value.
   virtual double GetSavedScreenMagnifierScale() = 0;
 
   // Triggers an accessibility alert to give the user feedback.
   virtual void TriggerAccessibilityAlert(AccessibilityAlert alert) = 0;
 
   // Gets the last accessibility alert that was triggered.
   virtual AccessibilityAlert GetLastAccessibilityAlert() = 0;
 
   // Initiates play of shutdown sound and returns it's duration.
   virtual base::TimeDelta PlayShutdownSound() const = 0;
 };
 
 }  // namespace ash
 
 #endif  // ASH_ACCESSIBILITYDELEGATE_H_