Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1024813002: Remove harmony-strings flag. (Closed)

Created:
5 years, 9 months ago by Dmitry Lomov (no reviews)
Modified:
5 years, 9 months ago
Reviewers:
yanngguo, rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove harmony-strings flag. String functions are shipping since 4.1/Chrome M41, it is time to unflag. R=yanngguo@chromium.org,rossberg@chromium.org BUG= Committed: https://crrev.com/af04fdfec837b6c2b5d005409f9ce4b615288782 Cr-Commit-Position: refs/heads/master@{#27337}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -1433 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
D src/harmony-string.js View 1 chunk +0 lines, -194 lines 0 comments Download
M src/string.js View 4 chunks +169 lines, -1 line 0 comments Download
M test/js-perf-test/JSTests.json View 1 chunk +0 lines, -1 line 0 comments Download
A + test/mjsunit/es6/string-codepointat.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/string-endswith.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/string-fromcodepoint.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/string-includes.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/string-repeat.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/string-startswith.js View 1 chunk +0 lines, -2 lines 0 comments Download
D test/mjsunit/harmony/disable-harmony-string.js View 1 chunk +0 lines, -7 lines 0 comments Download
D test/mjsunit/harmony/string-codepointat.js View 1 chunk +0 lines, -91 lines 0 comments Download
D test/mjsunit/harmony/string-endswith.js View 1 chunk +0 lines, -412 lines 0 comments Download
D test/mjsunit/harmony/string-fromcodepoint.js View 1 chunk +0 lines, -62 lines 0 comments Download
D test/mjsunit/harmony/string-includes.js View 1 chunk +0 lines, -166 lines 0 comments Download
D test/mjsunit/harmony/string-repeat.js View 1 chunk +0 lines, -77 lines 0 comments Download
D test/mjsunit/harmony/string-startswith.js View 1 chunk +0 lines, -403 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Dmitry Lomov (no reviews)
PTAL
5 years, 9 months ago (2015-03-20 10:06:24 UTC) #1
rossberg
lgtm
5 years, 9 months ago (2015-03-20 10:13:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024813002/1
5 years, 9 months ago (2015-03-20 10:21:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 10:43:39 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 10:43:54 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/af04fdfec837b6c2b5d005409f9ce4b615288782
Cr-Commit-Position: refs/heads/master@{#27337}

Powered by Google App Engine
This is Rietveld 408576698