Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 102473005: Refresh for the Chrome notifications image template. (Closed)

Created:
7 years ago by dewittj
Modified:
7 years ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Refresh for the Chrome notifications image template. Previously we auto-scaled all images up to fit a 360x540 rectangle. Since this is too big, we've reduced the rectangle to 360x240. Images that do not match this 3:2 aspect ratio will have a border applied, further reducing the max size to 340x220. This design allows for full bleed images for well-behaved notifiers but also a sleek look for other sizes of image. BUG=326224 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240290

Patch Set 1 : #

Total comments: 8

Patch Set 2 : Address comments. #

Patch Set 3 : Removes iffy use of static_cast to compute proportion. #

Patch Set 4 : Fix mac unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -38 lines) Patch
M chrome/browser/extensions/api/notifications/notifications_api.cc View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/renderer/resources/extensions/notifications_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/cocoa/notification_controller.mm View 1 2 7 chunks +56 lines, -18 lines 0 comments Download
M ui/message_center/cocoa/notification_controller_unittest.mm View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M ui/message_center/message_center_style.h View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M ui/message_center/message_center_style.cc View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M ui/message_center/views/notification_view.cc View 1 2 3 chunks +45 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dewittj
miket: notifications_custom_bindings.js rsesek: cocoa dimich: all
7 years ago (2013-12-05 18:19:53 UTC) #1
miket_OOO
On 2013/12/05 18:19:53, dewittj wrote: > miket: notifications_custom_bindings.js This part LGTM
7 years ago (2013-12-05 18:23:33 UTC) #2
Robert Sesek
cocoa/ LGTM https://codereview.chromium.org/102473005/diff/20001/ui/message_center/cocoa/notification_controller.mm File ui/message_center/cocoa/notification_controller.mm (right): https://codereview.chromium.org/102473005/diff/20001/ui/message_center/cocoa/notification_controller.mm#newcode643 ui/message_center/cocoa/notification_controller.mm:643: nit: extra line
7 years ago (2013-12-05 18:36:55 UTC) #3
Dmitry Titov
https://codereview.chromium.org/102473005/diff/20001/ui/message_center/message_center_style.h File ui/message_center/message_center_style.h (right): https://codereview.chromium.org/102473005/diff/20001/ui/message_center/message_center_style.h#newcode23 ui/message_center/message_center_style.h:23: const float kNotificationPreferredImageRatio = 0.6666667f; Why not just 0.67f ...
7 years ago (2013-12-06 19:29:11 UTC) #4
dewittj
I also removed the static_cast and consolidated all of our aspect ratio computations into the ...
7 years ago (2013-12-10 02:47:03 UTC) #5
Dmitry Titov
lgtm
7 years ago (2013-12-10 20:31:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/102473005/60001
7 years ago (2013-12-10 20:38:07 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) message_center_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=199812
7 years ago (2013-12-10 21:27:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/102473005/80001
7 years ago (2013-12-11 23:01:03 UTC) #9
commit-bot: I haz the power
7 years ago (2013-12-12 13:06:43 UTC) #10
Message was sent while issue was closed.
Change committed as 240290

Powered by Google App Engine
This is Rietveld 408576698