Refresh for the Chrome notifications image template.

Refresh for the Chrome notifications image template.

Previously we auto-scaled all images up to fit a 360x540 rectangle.
Since this is too big, we've reduced the rectangle to 360x240.  Images
that do not match this 3:2 aspect ratio will have a border applied,
further reducing the max size to 340x220. This design allows for full
bleed images for well-behaved notifiers but also a sleek look for other
sizes of image.

BUG=326224
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240290

[dewittj, 2013-12-05 18:19:53]

miket: notifications_custom_bindings.js
rsesek: cocoa
dimich: all

[miket_OOO, 2013-12-05 18:23:33]

On 2013/12/05 18:19:53, dewittj wrote:
> miket: notifications_custom_bindings.js

This part LGTM

[Robert Sesek, 2013-12-05 18:36:55]

cocoa/ LGTM

https://codereview.chromium.org/102473005/diff/20001/ui/message_center/cocoa/...
File ui/message_center/cocoa/notification_controller.mm (right):

https://codereview.chromium.org/102473005/diff/20001/ui/message_center/cocoa/...
ui/message_center/cocoa/notification_controller.mm:643: 
nit: extra line

[Dmitry Titov, 2013-12-06 19:29:11]

https://codereview.chromium.org/102473005/diff/20001/ui/message_center/messag...
File ui/message_center/message_center_style.h (right):

https://codereview.chromium.org/102473005/diff/20001/ui/message_center/messag...
ui/message_center/message_center_style.h:23: const float
kNotificationPreferredImageRatio = 0.6666667f;
Why not just 0.67f with a comment explaining the origin of this number? I doubt
the extra precision is visible, while raising a question why this specific
number of digits was choosen...

https://codereview.chromium.org/102473005/diff/20001/ui/message_center/views/...
File ui/message_center/views/notification_view.cc (right):

https://codereview.chromium.org/102473005/diff/20001/ui/message_center/views/...
ui/message_center/views/notification_view.cc:260: class NotificationImage :
public views::View {
Is it possible to avoid creating new class?
Can we get similar effect by setting a border, background and size on the
ProportionalImageView? Even if we need an additional background view, it can be
created when NotificaitonView's view tree is constructed. Having a separate
class does not have much value, since there is no methods to call later
(GetPreferredSize can be avoided by SetPreferredSize I think) nor specific
lifetime...

https://codereview.chromium.org/102473005/diff/20001/ui/message_center/views/...
ui/message_center/views/notification_view.cc:270: };
DISALLOW_COPY_AND_ASSIGN...

[dewittj, 2013-12-10 02:47:03]

I also removed the static_cast and consolidated all of our aspect ratio
computations into the function in message_center_style.cc

https://codereview.chromium.org/102473005/diff/20001/ui/message_center/cocoa/...
File ui/message_center/cocoa/notification_controller.mm (right):

https://codereview.chromium.org/102473005/diff/20001/ui/message_center/cocoa/...
ui/message_center/cocoa/notification_controller.mm:643: 
On 2013/12/05 18:36:56, rsesek wrote:
> nit: extra line

Done.

https://codereview.chromium.org/102473005/diff/20001/ui/message_center/messag...
File ui/message_center/message_center_style.h (right):

https://codereview.chromium.org/102473005/diff/20001/ui/message_center/messag...
ui/message_center/message_center_style.h:23: const float
kNotificationPreferredImageRatio = 0.6666667f;
On 2013/12/06 19:29:11, Dmitry Titov wrote:
> Why not just 0.67f with a comment explaining the origin of this number? I
doubt
> the extra precision is visible, while raising a question why this specific
> number of digits was choosen...

Done.

https://codereview.chromium.org/102473005/diff/20001/ui/message_center/views/...
File ui/message_center/views/notification_view.cc (right):

https://codereview.chromium.org/102473005/diff/20001/ui/message_center/views/...
ui/message_center/views/notification_view.cc:260: class NotificationImage :
public views::View {
On 2013/12/06 19:29:11, Dmitry Titov wrote:
> Is it possible to avoid creating new class?
> Can we get similar effect by setting a border, background and size on the
> ProportionalImageView? Even if we need an additional background view, it can
be
> created when NotificaitonView's view tree is constructed. Having a separate
> class does not have much value, since there is no methods to call later
> (GetPreferredSize can be avoided by SetPreferredSize I think) nor specific
> lifetime...

Done.

https://codereview.chromium.org/102473005/diff/20001/ui/message_center/views/...
ui/message_center/views/notification_view.cc:270: };
On 2013/12/06 19:29:11, Dmitry Titov wrote:
> DISALLOW_COPY_AND_ASSIGN...

Done.

[Dmitry Titov, 2013-12-10 20:31:12]

lgtm

[commit-bot: I haz the power, 2013-12-10 20:38:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dewittj@chromium.org/102473005/60001

[commit-bot: I haz the power, 2013-12-10 21:27:57]

Retried try job too often on mac_rel for step(s) message_center_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-12-11 23:01:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dewittj@chromium.org/102473005/80001

[commit-bot: I haz the power, 2013-12-12 13:06:43]

Change committed as 240290