Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1024723002: Add some trace points to mojo_shell for app lifetime (Closed)

Created:
5 years, 9 months ago by jamesr
Modified:
5 years, 8 months ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add some trace points to mojo_shell for app lifetime This adds some trace points to common mojo_shell operations to make it a bit easier to see what is going on. R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6bbb9e08c7fe51668ccf589e918f7fd3ce174325

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M shell/application_manager/application_manager.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M shell/application_manager/local_fetcher.cc View 2 chunks +2 lines, -0 lines 2 comments Download
M shell/application_manager/network_fetcher.cc View 3 chunks +4 lines, -0 lines 2 comments Download
M shell/context.cc View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jamesr
5 years, 9 months ago (2015-03-19 23:54:36 UTC) #1
jamesr
Thoughts?
5 years, 9 months ago (2015-03-23 22:57:29 UTC) #2
viettrungluu
LGTM w/comments (maybe recoard moar urls?) https://codereview.chromium.org/1024723002/diff/1/shell/application_manager/local_fetcher.cc File shell/application_manager/local_fetcher.cc (right): https://codereview.chromium.org/1024723002/diff/1/shell/application_manager/local_fetcher.cc#newcode33 shell/application_manager/local_fetcher.cc:33: TRACE_EVENT0("mojo_shell", "LocalFetcher::LocalFetcher"); Should ...
5 years, 9 months ago (2015-03-24 20:04:34 UTC) #3
jamesr
https://codereview.chromium.org/1024723002/diff/1/shell/application_manager/local_fetcher.cc File shell/application_manager/local_fetcher.cc (right): https://codereview.chromium.org/1024723002/diff/1/shell/application_manager/local_fetcher.cc#newcode33 shell/application_manager/local_fetcher.cc:33: TRACE_EVENT0("mojo_shell", "LocalFetcher::LocalFetcher"); On 2015/03/24 20:04:34, viettrungluu wrote: > Should ...
5 years, 8 months ago (2015-03-27 20:42:21 UTC) #4
jamesr
5 years, 8 months ago (2015-03-27 20:42:44 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6bbb9e08c7fe51668ccf589e918f7fd3ce174325 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698