src/x64/full-codegen-x64.cc - Issue 1024703004: Cleanups needed for this-scoping in arrow functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/full-codegen-x64.cc

Issue 1024703004: Cleanups needed for this-scoping in arrow functions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/full-codegen-x64.cc

diff --git a/src/x64/full-codegen-x64.cc b/src/x64/full-codegen-x64.cc

index 64717b979db00d8884583ba4d74060bf1906c5c7..ac21199008919dd872cc80d39413b0c3337c01ad 100644

--- a/src/x64/full-codegen-x64.cc

+++ b/src/x64/full-codegen-x64.cc

@@ -114,7 +114,8 @@ void FullCodeGenerator::Generate() {

// Sloppy mode functions and builtins need to replace the receiver with the

// global proxy when called as functions (without an explicit receiver

// object).

- if (is_sloppy(info->language_mode()) && !info->is_native()) {

+ if (is_sloppy(info->language_mode()) && !info->is_native() &&

+ info->scope()->has_this_declaration()) {

Label ok;

// +1 for return address.

StackArgumentsAccessor args(rsp, info->scope()->num_parameters());