src/arm64/lithium-codegen-arm64.cc - Issue 1024703004: Cleanups needed for this-scoping in arrow functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/lithium-codegen-arm64.cc

Issue 1024703004: Cleanups needed for this-scoping in arrow functions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm64/lithium-codegen-arm64.cc

diff --git a/src/arm64/lithium-codegen-arm64.cc b/src/arm64/lithium-codegen-arm64.cc

index 3f7644962907b33b4a1f341b146e9cad3398e932..75978892b1a730e7befc683446c1bdd5c69892ac 100644

--- a/src/arm64/lithium-codegen-arm64.cc

+++ b/src/arm64/lithium-codegen-arm64.cc

@@ -664,7 +664,7 @@ bool LCodeGen::GeneratePrologue() {

// global proxy when called as functions (without an explicit receiver

// object).

if (info_->this_has_uses() && is_sloppy(info_->language_mode()) &&

- !info_->is_native()) {

+ !info_->is_native() && info_->scope()->has_this_declaration()) {

Label ok;

int receiver_offset = info_->scope()->num_parameters() * kXRegSize;

__ Peek(x10, receiver_offset);