Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 1024703004: Cleanups needed for this-scoping in arrow functions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/arm/lithium-codegen-arm.h" 7 #include "src/arm/lithium-codegen-arm.h"
8 #include "src/arm/lithium-gap-resolver-arm.h" 8 #include "src/arm/lithium-gap-resolver-arm.h"
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 // r1: Callee's JS function. 114 // r1: Callee's JS function.
115 // cp: Callee's context. 115 // cp: Callee's context.
116 // pp: Callee's constant pool pointer (if FLAG_enable_ool_constant_pool) 116 // pp: Callee's constant pool pointer (if FLAG_enable_ool_constant_pool)
117 // fp: Caller's frame pointer. 117 // fp: Caller's frame pointer.
118 // lr: Caller's pc. 118 // lr: Caller's pc.
119 119
120 // Sloppy mode functions and builtins need to replace the receiver with the 120 // Sloppy mode functions and builtins need to replace the receiver with the
121 // global proxy when called as functions (without an explicit receiver 121 // global proxy when called as functions (without an explicit receiver
122 // object). 122 // object).
123 if (info_->this_has_uses() && is_sloppy(info_->language_mode()) && 123 if (info_->this_has_uses() && is_sloppy(info_->language_mode()) &&
124 !info_->is_native()) { 124 !info_->is_native() && info_->scope()->has_this_declaration()) {
125 Label ok; 125 Label ok;
126 int receiver_offset = info_->scope()->num_parameters() * kPointerSize; 126 int receiver_offset = info_->scope()->num_parameters() * kPointerSize;
127 __ ldr(r2, MemOperand(sp, receiver_offset)); 127 __ ldr(r2, MemOperand(sp, receiver_offset));
128 __ CompareRoot(r2, Heap::kUndefinedValueRootIndex); 128 __ CompareRoot(r2, Heap::kUndefinedValueRootIndex);
129 __ b(ne, &ok); 129 __ b(ne, &ok);
130 130
131 __ ldr(r2, GlobalObjectOperand()); 131 __ ldr(r2, GlobalObjectOperand());
132 __ ldr(r2, FieldMemOperand(r2, GlobalObject::kGlobalProxyOffset)); 132 __ ldr(r2, FieldMemOperand(r2, GlobalObject::kGlobalProxyOffset));
133 133
134 __ str(r2, MemOperand(sp, receiver_offset)); 134 __ str(r2, MemOperand(sp, receiver_offset));
(...skipping 5801 matching lines...) Expand 10 before | Expand all | Expand 10 after
5936 __ Push(scope_info); 5936 __ Push(scope_info);
5937 __ push(ToRegister(instr->function())); 5937 __ push(ToRegister(instr->function()));
5938 CallRuntime(Runtime::kPushBlockContext, 2, instr); 5938 CallRuntime(Runtime::kPushBlockContext, 2, instr);
5939 RecordSafepoint(Safepoint::kNoLazyDeopt); 5939 RecordSafepoint(Safepoint::kNoLazyDeopt);
5940 } 5940 }
5941 5941
5942 5942
5943 #undef __ 5943 #undef __
5944 5944
5945 } } // namespace v8::internal 5945 } } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698