Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1024703002: Roll PDFium (Closed)

Created:
5 years, 9 months ago by Tom Sepez
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang, brettw
CC:
chromium-reviews, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll PDFium A newer version of PDFium is needed to unblock GN work. Sheriffs: Revert first and ask questions later. This has been a stubborn roll to get clean. Sorry. This pulls in: da06966 Flush stdout before launching sub-processes. b011566 Try to make a NOTREACHED definition suitable for win8. 3acf438 Roll DEPS to pull in full, regenerated corpus of tests 7b4c002 Turn down warning level for GN build of image_diff utility ae702b0 Fix missing include for std::min fa7cf56 Revert corpus to last known working version. 2ef9809 Fix corpus roll broken in the previous commit. f2d7b2d Bring in entire corpus for testing. 76a61ca Pull in specific revision of PDF corpus via DEPS. d1f792a Fix subtle issues in opj_skip_from_memory and add unit tests. 74b81d9 Revert "TEST that the tree goes RED when pixel/javascript tests fail." This reverts commit de00893874a9d5ecae497e00511e2395fc2f02e8. de00893 TEST that the tree goes RED when pixel/javascript tests fail. 2c4f5ea Return OS status code from python test driver scripts. a416173 Revert "Fix a problem that JP2 image is not displayed because index color space is used" b29e12a Pull our new test case repository via deps. a7865e9 Speculative fix for breakage in pdfum DEPS roll 5a0e504 Fix a problem that JP2 image is not displayed because index color space is used cd3c476 Fix a bug that JPX images can't be shown ae5b85a Fix potential integer overflow in fpdf_render_image.cpp b8cd18a Revert "Kill CFX_GrowOnlyPool." 090d683 Kill CFX_GrowOnlyPool. 3c676ec Kill remaining sprintfs 1e580a1 Fix multiply defined macro in zlib.h on linux_chromium_clobber_rel_ng builder. 0700106 Make conversions for CPDF_Link explicit. 8842c62 Fix the pdfium component build. 5a370d7 Make conversion between CPDF_Dest and its object explicit. 7348fae Add gmock to .gitignore 624b6c1 Make conversion between CPDF_Action and its dictionary explicit. 61c25ee Merge to Master: Fix a compiling error in fxjs_v8.h e1671bd Kill off JS_ErrorString type. b720d0a Return error information from pdfium to JS. 944ccad Do hit tests against Annots in reverse order. 5b47dbf Remove unused IDS_ constants from pdfium. 3d25502 Pull in gmock for standalone pdfium builds. ec61a85 Upgrade openjpeg to revision 2997. 42a8ada Implement a delegate for EmbedderTests. 57e4c86 Kill off unused IFXJS interface methods. 4351ac2 Fix compilation error on Windows. f9cfdda Add small flate decode unit test. e796478 Kill multi-byte comments in fxet_list.h 23f9288 Convert pdfium expected test results to PNG format. 0fd53cf Fix GN build after PNG support backport ef1e85c Backport PNG output format to origin/master branch. Committed: https://crrev.com/a74f4d2439523e741cca6868c9be11c4a117cf91 Cr-Commit-Position: refs/heads/master@{#321618} Committed: https://crrev.com/8f7ecfe1f2966a2954261e22b6576e505c04505f Cr-Commit-Position: refs/heads/master@{#321862}

Patch Set 1 #

Patch Set 2 : Pick up #include fix #

Patch Set 3 : Try Try again #

Patch Set 4 : Next attempt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (14 generated)
Tom Sepez
5 years, 9 months ago (2015-03-19 23:49:06 UTC) #2
brettw
lgtm
5 years, 9 months ago (2015-03-19 23:49:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024703002/1
5 years, 9 months ago (2015-03-19 23:51:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024703002/1
5 years, 9 months ago (2015-03-19 23:53:07 UTC) #9
Lei Zhang
lgtm, BUG= would've been nice to have.
5 years, 9 months ago (2015-03-19 23:53:51 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/66003)
5 years, 9 months ago (2015-03-20 00:37:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024703002/20001
5 years, 9 months ago (2015-03-20 17:58:49 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-20 20:06:50 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a74f4d2439523e741cca6868c9be11c4a117cf91 Cr-Commit-Position: refs/heads/master@{#321618}
5 years, 9 months ago (2015-03-20 20:07:36 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024703002/60001
5 years, 9 months ago (2015-03-23 18:49:34 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024703002/60001
5 years, 9 months ago (2015-03-23 20:21:46 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-23 21:42:20 UTC) #26
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 21:43:31 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8f7ecfe1f2966a2954261e22b6576e505c04505f
Cr-Commit-Position: refs/heads/master@{#321862}

Powered by Google App Engine
This is Rietveld 408576698