Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: src/scanner.cc

Issue 1024603002: Remove --harmony-numeric-literal flag (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: git rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/scanner.h ('k') | test/cctest/test-parsing.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/scanner.cc
diff --git a/src/scanner.cc b/src/scanner.cc
index a40688f52b8a54ca500a868452faafcdd88a0650..8059289b7705d982d77767251f26961bdea8f60a 100644
--- a/src/scanner.cc
+++ b/src/scanner.cc
@@ -36,7 +36,6 @@ Scanner::Scanner(UnicodeCache* unicode_cache)
: unicode_cache_(unicode_cache),
octal_pos_(Location::invalid()),
harmony_modules_(false),
- harmony_numeric_literals_(false),
harmony_classes_(false),
harmony_unicode_(false) {}
@@ -954,7 +953,7 @@ Token::Value Scanner::ScanNumber(bool seen_period) {
while (IsHexDigit(c0_)) {
AddLiteralCharAdvance();
}
- } else if (harmony_numeric_literals_ && (c0_ == 'o' || c0_ == 'O')) {
+ } else if (c0_ == 'o' || c0_ == 'O') {
kind = OCTAL;
AddLiteralCharAdvance();
if (!IsOctalDigit(c0_)) {
@@ -964,7 +963,7 @@ Token::Value Scanner::ScanNumber(bool seen_period) {
while (IsOctalDigit(c0_)) {
AddLiteralCharAdvance();
}
- } else if (harmony_numeric_literals_ && (c0_ == 'b' || c0_ == 'B')) {
+ } else if (c0_ == 'b' || c0_ == 'B') {
kind = BINARY;
AddLiteralCharAdvance();
if (!IsBinaryDigit(c0_)) {
« no previous file with comments | « src/scanner.h ('k') | test/cctest/test-parsing.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698