Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 1024603002: Remove --harmony-numeric-literal flag (Closed)

Created:
5 years, 9 months ago by arv (Not doing code reviews)
Modified:
5 years, 8 months ago
Reviewers:
rossberg, adamk, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove --harmony-numeric-literal flag We have been shipping harmony numeric literals since M41 R=rossberg@chromium.org LOG=Y Committed: https://crrev.com/a373b089e98ecdb5ac64506a95c54d152dc2b2d9 Cr-Commit-Position: refs/heads/master@{#27545}

Patch Set 1 : #

Patch Set 2 : git rebase #

Patch Set 3 : git rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -42 lines) Patch
M src/bootstrapper.cc View 1 2 3 chunks +0 lines, -3 lines 0 comments Download
M src/flag-definitions.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/parser.cc View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M src/preparser.h View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M src/runtime/runtime-numbers.cc View 1 chunk +1 line, -7 lines 0 comments Download
M src/scanner.h View 1 2 2 chunks +0 lines, -8 lines 0 comments Download
M src/scanner.cc View 1 2 3 chunks +2 lines, -3 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 2 4 chunks +2 lines, -7 lines 0 comments Download
M test/mjsunit/es6/numeric-literals.js View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
arv (Not doing code reviews)
PTAL
5 years, 9 months ago (2015-03-19 18:36:27 UTC) #2
adamk
lgtm
5 years, 9 months ago (2015-03-20 08:56:19 UTC) #4
rossberg
lgtm
5 years, 9 months ago (2015-03-20 10:15:40 UTC) #5
arv (Not doing code reviews)
git rebase
5 years, 9 months ago (2015-03-20 15:01:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024603002/40001
5 years, 9 months ago (2015-03-20 15:01:52 UTC) #9
arv (Not doing code reviews)
FWIW, the tests were already in test/mjsunit/es6/
5 years, 9 months ago (2015-03-20 15:02:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024603002/40001
5 years, 9 months ago (2015-03-23 08:07:10 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/4222)
5 years, 9 months ago (2015-03-23 08:09:48 UTC) #15
arv (Not doing code reviews)
On 2015/03/23 08:09:48, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 9 months ago (2015-03-24 10:03:53 UTC) #16
arv (Not doing code reviews)
git rebase
5 years, 8 months ago (2015-03-31 14:01:09 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024603002/60001
5 years, 8 months ago (2015-03-31 14:01:34 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 8 months ago (2015-03-31 14:24:20 UTC) #21
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 14:24:42 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a373b089e98ecdb5ac64506a95c54d152dc2b2d9
Cr-Commit-Position: refs/heads/master@{#27545}

Powered by Google App Engine
This is Rietveld 408576698