Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1024583003: Fix for menus blocking user activity detection (Retry 2). (Closed)

Created:
5 years, 9 months ago by afakhry
Modified:
5 years, 9 months ago
Reviewers:
oshima, James Cook, sadrul, spang
CC:
chromium-reviews, ozone-reviews_chromium.org, kalyank, sadrul, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for menus blocking user activity detection (Retry 2). Original CL reverted here: https://codereview.chromium.org/1013003002/ Nothing has changed from that CL above. We are relanding after Oshima prevented marking events created from the same native event as "repeat" in this CL https://codereview.chromium.org/1017323002/ Menus used to block detecting user activity. The fix works by making the UserActivityDetector a PlatformEventObserver rather than an EventHandler. Also made sure that PlatformEventSource has an instance in ozone_platform_test.cc TBR=sadrul@chromium.org,spang@chromium.org,oshima@chromium.org,jamescook@chromium.org BUG=462735 TEST=ui_base_unittests --gtest_filter=UserActivityDetectorTest.* Committed: https://crrev.com/dbfa9102e7c6dfa13439ef1502d4baa9c3a31f31 Cr-Commit-Position: refs/heads/master@{#321426}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -52 lines) Patch
M ash/shell.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M extensions/shell/browser/shell_desktop_controller_aura.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/base/user_activity/user_activity_detector.h View 2 chunks +11 lines, -8 lines 0 comments Download
M ui/base/user_activity/user_activity_detector.cc View 3 chunks +33 lines, -22 lines 0 comments Download
M ui/base/user_activity/user_activity_detector_unittest.cc View 14 chunks +31 lines, -13 lines 0 comments Download
M ui/ozone/platform/test/ozone_platform_test.cc View 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
afakhry
(Retry) The exact same original CL after Oshima prevented marking events created from the same ...
5 years, 9 months ago (2015-03-19 18:25:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024583003/1
5 years, 9 months ago (2015-03-19 18:58:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024583003/1
5 years, 9 months ago (2015-03-19 20:10:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 20:40:03 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dbfa9102e7c6dfa13439ef1502d4baa9c3a31f31 Cr-Commit-Position: refs/heads/master@{#321426}
5 years, 9 months ago (2015-03-19 20:41:24 UTC) #8
spang
5 years, 8 months ago (2015-04-02 01:31:06 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1053773003/ by spang@chromium.org.

The reason for reverting is: Breaks multiple clicking on 2nd display.

Powered by Google App Engine
This is Rietveld 408576698