Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1024563005: media: Remove kRAConsentGranted pref. (Closed)

Created:
5 years, 9 months ago by xhwang
Modified:
5 years, 8 months ago
Reviewers:
Darren Krahn, sky, *ddorwin
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Remove kRAConsentGranted pref. Now protected media identifier content setting is not synced, we don't need kRAConsentGranted pref any more. Whether we should prompt user solely depends on the content setting status. TBR=sky@chromium.org BUG=468569 TEST=Manually tested. Committed: https://crrev.com/0ef984eae4e562fc9e0b7ae23f9a4de778e3881f Cr-Commit-Position: refs/heads/master@{#323779}

Patch Set 1 #

Patch Set 2 : rebase only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -42 lines) Patch
M chrome/browser/media/protected_media_identifier_permission_context.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/media/protected_media_identifier_permission_context.cc View 1 5 chunks +5 lines, -32 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
xhwang
PTAL
5 years, 9 months ago (2015-03-23 16:48:15 UTC) #2
ddorwin
lgtm
5 years, 9 months ago (2015-03-23 17:23:21 UTC) #5
ddorwin
The CL originally in the description (I removed it) has landed. This is now blocked ...
5 years, 8 months ago (2015-04-02 18:01:40 UTC) #6
xhwang
rebase only
5 years, 8 months ago (2015-04-03 16:59:25 UTC) #7
xhwang
TBRing sky@ for removing a line in chrome/browser/prefs/browser_prefs.cc.
5 years, 8 months ago (2015-04-03 17:01:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024563005/20001
5 years, 8 months ago (2015-04-03 17:49:05 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-03 18:30:05 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:39:22 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0ef984eae4e562fc9e0b7ae23f9a4de778e3881f
Cr-Commit-Position: refs/heads/master@{#323779}

Powered by Google App Engine
This is Rietveld 408576698