Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1024553005: Fix mounting read-only volumes in Files app. (Closed)

Created:
5 years, 9 months ago by mtomasz
Modified:
5 years, 9 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix mounting read-only volumes in Files app. The new logic was trying to mount all volumes in R/W mode, which was failing for read-only volumes. TEST=Tested manually with read only volumes. BUG=None Committed: https://crrev.com/1e91e5fc31e45c219ac57366b058e4890bb044bd Cr-Commit-Position: refs/heads/master@{#321938}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/file_manager/file_manager/background/js/volume_manager.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
mtomasz
@hirono: PTAL. Thanks.
5 years, 9 months ago (2015-03-24 05:02:27 UTC) #2
hirono
lgtm, sorry for missing it. Thanks!
5 years, 9 months ago (2015-03-24 05:26:43 UTC) #3
mtomasz
On 2015/03/24 05:26:43, hirono wrote: > lgtm, sorry for missing it. Thanks! thanks!
5 years, 9 months ago (2015-03-24 05:26:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024553005/1
5 years, 9 months ago (2015-03-24 05:27:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 05:46:35 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 05:47:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e91e5fc31e45c219ac57366b058e4890bb044bd
Cr-Commit-Position: refs/heads/master@{#321938}

Powered by Google App Engine
This is Rietveld 408576698