chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.h - Issue 1024553004: Autofill OSX: Add RetriableErrorMessage text label.

Side by Side Diff: chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.h

Issue 1024553004: Autofill OSX: Add RetriableErrorMessage text label. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm » ('j') | chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_COCOA_CARD_UNMASK_PROMPT_VIEW_BRIDGE_H_	5 #ifndef CHROME_BROWSER_UI_COCOA_CARD_UNMASK_PROMPT_VIEW_BRIDGE_H_

6 #define CHROME_BROWSER_UI_COCOA_CARD_UNMASK_PROMPT_VIEW_BRIDGE_H_	6 #define CHROME_BROWSER_UI_COCOA_CARD_UNMASK_PROMPT_VIEW_BRIDGE_H_

7	7

8 #include "base/mac/scoped_nsobject.h"	8 #include "base/mac/scoped_nsobject.h"

9 #include "base/memory/scoped_ptr.h"	9 #include "base/memory/scoped_ptr.h"

10 #include "chrome/browser/ui/autofill/card_unmask_prompt_view.h"	10 #include "chrome/browser/ui/autofill/card_unmask_prompt_view.h"

(...skipping 37 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
48	48

49 } // autofill	49 } // autofill

50	50

51 @interface CardUnmaskPromptViewCocoa	51 @interface CardUnmaskPromptViewCocoa

52 : NSViewController<NSWindowDelegate, NSTextFieldDelegate>	52 : NSViewController<NSWindowDelegate, NSTextFieldDelegate>

53	53

54 // Designated initializer. \|bridge\| must not be NULL.	54 // Designated initializer. \|bridge\| must not be NULL.

55 - (id)initWithBridge:(autofill::CardUnmaskPromptViewBridge*)bridge;	55 - (id)initWithBridge:(autofill::CardUnmaskPromptViewBridge*)bridge;

56	56

57 - (void)setProgressOverlayText:(const base::string16&)text;	57 - (void)setProgressOverlayText:(const base::string16&)text;

	58 - (void)setRetriableErrorMessage:(const base::string16&)text;
	groby-ooo-7-16 2015/03/24 01:26:49 Retryable. (Ideally, just setErrorMessage - if you Retryable. (Ideally, just setErrorMessage - if you can't retry it, probably setFatalErrorMessage, if we must distinguish) Evan Stade 2015/03/24 16:07:40 what's wrong with retriable? Neither retriable nor Show quoted text On 2015/03/24 01:26:49, groby wrote: > Retryable. (Ideally, just setErrorMessage - if you can't retry it, probably > setFatalErrorMessage, if we must distinguish) what's wrong with retriable? Neither retriable nor retryable is in my spellcheck dictionary but both of them show up with decent frequency in a google search. groby-ooo-7-16 2015/03/24 20:54:11 Maybe just my preference? For my searches, retryab Show quoted text On 2015/03/24 16:07:40, Evan Stade wrote: > On 2015/03/24 01:26:49, groby wrote: > > Retryable. (Ideally, just setErrorMessage - if you can't retry it, probably > > setFatalErrorMessage, if we must distinguish) > > what's wrong with retriable? Neither retriable nor retryable is in my spellcheck > dictionary but both of them show up with decent frequency in a google search. Maybe just my preference? For my searches, retryable outnumbers retriable 3:1, though. (And triable refers to legal trials, AIUI). But if everybody is attached to retriable, fine. I think this particular shed is fine in multiple colors :)
58	59

59 @end	60 @end

60	61

61 #endif // CHROME_BROWSER_UI_COCOA_CARD_UNMASK_PROMPT_VIEW_BRIDGE_H_	62 #endif // CHROME_BROWSER_UI_COCOA_CARD_UNMASK_PROMPT_VIEW_BRIDGE_H_

OLD	NEW