Issue 1024553003: [Suggestions Service] Enable Suggestions Service by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1024553003: [Suggestions Service] Enable Suggestions Service by default (Closed)

Created:
5 years, 9 months ago by beaudoin

Modified:
5 years, 9 months ago

Reviewers:
Mathieu

CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Enable SuggestionsService by default. BUG=387105 Committed: https://crrev.com/2daab5f9f504e09ac8b76083846c306f6e0d6042 Cr-Commit-Position: refs/heads/master@{#321474}

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -12 lines)			Patch
M	chrome/browser/search/suggestions/suggestions_service_factory.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	components/suggestions/suggestions_service.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	components/suggestions/suggestions_service.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024553003/1

5 years, 9 months ago (2015-03-19 21:20:39 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-20 00:06:35 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2daab5f9f504e09ac8b76083846c306f6e0d6042
Cr-Commit-Position: refs/heads/master@{#321474}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages