[RenderText] added test for AppendText

ui/gfx/render_text_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/render_text.h"
 
 #include <algorithm>
 
 #include "base/format_macros.h"
 #include "base/i18n/break_iterator.h"
@@ skipping 334 matching lines @@
   render_text->ApplyStyle(UNDERLINE, true, Range(2, 5));
   std::vector<std::pair<size_t, bool> > expected_underline;
   expected_underline.push_back(std::pair<size_t, bool>(0, false));
   expected_underline.push_back(std::pair<size_t, bool>(1, true));
   expected_underline.push_back(std::pair<size_t, bool>(6, false));
   EXPECT_TRUE(render_text->styles()[UNDERLINE].EqualsForTesting(
       expected_underline));
 #endif  // OS_MACOSX
 }
 
+TEST_F(RenderTextTest, AppendText) {
+  // Ensure AppendText maintains current text styles.
+  scoped_ptr<RenderText> render_text(RenderText::CreateInstance());
+  const SkColor color = SK_ColorRED;
+  render_text->SetColor(color);
+  render_text->SetBaselineStyle(SUPERSCRIPT);
+  render_text->SetStyle(BOLD, true);
+  render_text->SetStyle(UNDERLINE, false);
+  const wchar_t* const cases[] = {L"Hello", L"", L" ", L"world"};
+  size_t total_length = 0;
+  for (size_t i = 0; i < arraysize(cases); ++i) {
+    EXPECT_TRUE(render_text->colors().EqualsValueForTesting(color));
+    EXPECT_TRUE(render_text->baselines().EqualsValueForTesting(SUPERSCRIPT));
+    EXPECT_TRUE(render_text->styles()[BOLD].EqualsValueForTesting(true));
+    EXPECT_TRUE(render_text->styles()[UNDERLINE].EqualsValueForTesting(false));
+    EXPECT_EQ(total_length, render_text->GetDisplayText().length());
+    base::string16 str = WideToUTF16(cases[i]);
+    render_text->AppendText(str);
+    total_length += str.length();
+    EXPECT_EQ(total_length, render_text->GetDisplayText().length());
+    std::vector<std::pair<size_t, SkColor>> expected_color;
+    expected_color.push_back(std::pair<size_t, SkColor>(0, color));

[msw, 2015/03/24 20:06:03]

None of this makes sense... Call ApplyStyle / ApplyColor / ApplyBaseLineStyle...

This test would be a lot simpler if you removed the loop and just did:
  // Set some text with ranged styles, colors, and baseline styles.
  set text ("abc")
  apply style (underline, true, 1-2) ... etc ...
  vector expected (0=false, 1=true, 2=false) ... etc ...
  expect style[underline]==expected ... etc ...
  // Append some text and ensure that ranged styles are not lost.
  append text ("def")
  expect text=="abcdef"
  expect style[underline]==expected .... etc ...

[dschuyler, 2015/03/24 20:54:08]

Done.

+    EXPECT_TRUE(render_text->colors().EqualsForTesting(expected_color));
+    std::vector<std::pair<size_t, bool>> expected_bold;
+    expected_bold.push_back(std::pair<size_t, bool>(0, true));
+    EXPECT_TRUE(render_text->styles()[BOLD].EqualsForTesting(expected_bold));
+    std::vector<std::pair<size_t, BaselineStyle>> expected_baseline;
+    expected_baseline.push_back(
+        std::pair<size_t, BaselineStyle>(0, SUPERSCRIPT));
+    EXPECT_TRUE(render_text->baselines().EqualsForTesting(expected_baseline));
+  }
+  const base::string16 result_string = ASCIIToUTF16("Hello world");
+  EXPECT_EQ(render_text->GetDisplayText(), result_string);
+}
+
 // TODO(asvitkine): Cursor movements tests disabled on Mac because RenderTextMac
 //                  does not implement this yet. http://crbug.com/131618
 #if !defined(OS_MACOSX)
 void TestVisualCursorMotionInObscuredField(RenderText* render_text,
                                            const base::string16& text,
                                            bool select) {
   ASSERT_TRUE(render_text->obscured());
   render_text->SetText(text);
   int len = text.length();
   render_text->MoveCursor(LINE_BREAK, CURSOR_RIGHT, select);
@@ skipping 2457 matching lines @@
   string_size.set_width(string_size.width() / 2);
   render_text.SetDisplayRect(gfx::Rect(string_size));
   render_text.EnsureLayout();
   CFIndex glyph_count = CTLineGetGlyphCount(render_text.line_);
   EXPECT_GT(text.size(), static_cast<size_t>(glyph_count));
   EXPECT_NE(0, glyph_count);
 }
 #endif
 
 }  // namespace gfx