[RenderText] added test for AppendText

ui/gfx/render_text_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/render_text.h"
 
 #include <algorithm>
 
 #include "base/format_macros.h"
 #include "base/i18n/break_iterator.h"
@@ skipping 198 matching lines @@
   int row_count_;
 
   DISALLOW_COPY_AND_ASSIGN(TestRectangleBuffer);
 };
 
 }  // namespace
 
 class RenderTextTest : public testing::Test {
 };
 
+TEST_F(RenderTextTest, AppendText) {

[msw, 2015/03/24 01:47:16]

Move this test below ApplyStyles.

[dschuyler, 2015/03/24 19:37:08]

Done.

+  // Ensure AppendText maintains current text styles.
+  scoped_ptr<RenderText> render_text(RenderText::CreateInstance());
+  const SkColor color = SK_ColorRED;
+  render_text->SetColor(color);

[msw, 2015/03/24 01:47:16]

This test should also ensure ranged values from Apply[Color|Style|BaselineStyle]
aren't lost on AppendText. As is, this test doesn't ensure anything beyond the
SetStyles test, and would pass even if ranged styles were cleared on AppendText.

+  render_text->SetBaselineStyle(SUPERSCRIPT);
+  render_text->SetStyle(BOLD, true);
+  render_text->SetStyle(UNDERLINE, false);
+  const wchar_t* const cases[] = { L"Hello", L"", L" ", L"world" };
+  size_t total_length = 0;
+  for (size_t i = 0; i < arraysize(cases); ++i) {
+    EXPECT_TRUE(render_text->colors().EqualsValueForTesting(color));
+    EXPECT_TRUE(render_text->baselines().EqualsValueForTesting(SUPERSCRIPT));
+    EXPECT_TRUE(render_text->styles()[BOLD].EqualsValueForTesting(true));
+    EXPECT_TRUE(render_text->styles()[UNDERLINE].EqualsValueForTesting(false));
+    EXPECT_EQ(total_length, render_text->GetDisplayText().length());
+    base::string16 str = WideToUTF16(cases[i]);
+    render_text->AppendText(str);
+    total_length += str.length();
+    EXPECT_EQ(total_length, render_text->GetDisplayText().length());
+  }
+  const base::string16 result_string = ASCIIToUTF16("Hello world");
+  EXPECT_EQ(render_text->GetDisplayText(), result_string);
+}
+
 TEST_F(RenderTextTest, DefaultStyles) {
   // Check the default styles applied to new instances and adjusted text.
   scoped_ptr<RenderText> render_text(RenderText::CreateInstance());
   EXPECT_TRUE(render_text->text().empty());
   const wchar_t* const cases[] = { kWeak, kLtr, L"Hello", kRtl, L"", L"" };
   for (size_t i = 0; i < arraysize(cases); ++i) {
     EXPECT_TRUE(render_text->colors().EqualsValueForTesting(SK_ColorBLACK));
     EXPECT_TRUE(
         render_text->baselines().EqualsValueForTesting(NORMAL_BASELINE));
     for (size_t style = 0; style < NUM_TEXT_STYLES; ++style)
@@ skipping 2593 matching lines @@
   string_size.set_width(string_size.width() / 2);
   render_text.SetDisplayRect(gfx::Rect(string_size));
   render_text.EnsureLayout();
   CFIndex glyph_count = CTLineGetGlyphCount(render_text.line_);
   EXPECT_GT(text.size(), static_cast<size_t>(glyph_count));
   EXPECT_NE(0, glyph_count);
 }
 #endif
 
 }  // namespace gfx