Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Unified Diff: Source/platform/LifecycleContextTest.cpp

Issue 1024543004: Disallow adding ContextLifecycleObservers during iteration. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: tidier LifecycleObserver ctor Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/PageLifecycleObserver.cpp ('k') | Source/platform/LifecycleNotifier.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/LifecycleContextTest.cpp
diff --git a/Source/platform/LifecycleContextTest.cpp b/Source/platform/LifecycleContextTest.cpp
index 37f85a356cf7ebe1494ad34f1c1d75f809aa8f68..883e26d8d8e8c43de2c09ea1005b071855ff62b9 100644
--- a/Source/platform/LifecycleContextTest.cpp
+++ b/Source/platform/LifecycleContextTest.cpp
@@ -61,7 +61,7 @@ public:
virtual void contextDestroyed() override
{
- LifecycleObserver<DummyContext, TestingObserver, DummyContext>::contextDestroyed();
+ LifecycleObserver::contextDestroyed();
if (m_observerToRemoveOnDestruct) {
lifecycleContext()->removeObserver(m_observerToRemoveOnDestruct.get());
m_observerToRemoveOnDestruct.clear();
@@ -72,7 +72,7 @@ public:
DEFINE_INLINE_TRACE()
{
visitor->trace(m_observerToRemoveOnDestruct);
- LifecycleObserver<DummyContext, TestingObserver, DummyContext>::trace(visitor);
+ LifecycleObserver::trace(visitor);
}
void unobserve() { setContext(nullptr); }
@@ -88,9 +88,9 @@ public:
private:
explicit TestingObserver(DummyContext* context)
- : m_contextDestroyedCalled(false)
+ : LifecycleObserver(context)
+ , m_contextDestroyedCalled(false)
{
- setContext(context);
}
OwnPtrWillBeMember<TestingObserver> m_observerToRemoveOnDestruct;
« no previous file with comments | « Source/core/page/PageLifecycleObserver.cpp ('k') | Source/platform/LifecycleNotifier.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698