Source/core/frame/DOMWindowLifecycleObserver.h - Issue 1024543004: Disallow adding ContextLifecycleObservers during iteration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/DOMWindowLifecycleObserver.h

Issue 1024543004: Disallow adding ContextLifecycleObservers during iteration. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: tidier LifecycleObserver ctor Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/DOMWindowLifecycleObserver.h

diff --git a/Source/core/frame/DOMWindowLifecycleObserver.h b/Source/core/frame/DOMWindowLifecycleObserver.h

index f6b38d144585355dd2cf2096580181d9eb30dc78..9473a3df52264800c44be29369f4f49f2a5302c0 100644

--- a/Source/core/frame/DOMWindowLifecycleObserver.h

+++ b/Source/core/frame/DOMWindowLifecycleObserver.h

@@ -43,7 +43,10 @@ public:

virtual void didRemoveAllEventListeners(LocalDOMWindow*) { }

protected:

- explicit DOMWindowLifecycleObserver(LocalDOMWindow*);

+ explicit DOMWindowLifecycleObserver(LocalDOMWindow* window)

+ : LifecycleObserver(window)

+ {

+ }

};

} // namespace blink

« no previous file with comments | « Source/core/dom/DocumentLifecycleObserver.cpp ('k') | Source/core/frame/DOMWindowLifecycleObserver.cpp » ('j') | no next file with comments »