Source/platform/LifecycleObserver.h - Issue 1024543004: Disallow adding ContextLifecycleObservers during iteration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/LifecycleObserver.h

Issue 1024543004: Disallow adding ContextLifecycleObservers during iteration. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/LifecycleObserver.h

diff --git a/Source/platform/LifecycleObserver.h b/Source/platform/LifecycleObserver.h

index 6637428da094e1f927fe49f5baeec6b75879bacb..5e99c383cec7a16068d09a5e87778cd20609f85a 100644

--- a/Source/platform/LifecycleObserver.h

+++ b/Source/platform/LifecycleObserver.h

@@ -37,9 +37,10 @@ class LifecycleObserver : public WillBeGarbageCollectedMixin {

public:

using Context = T;

- LifecycleObserver()

+ LifecycleObserver(Context* context)

haraken 2015/03/23 14:30:43 Add explicit.

sof 2015/03/23 15:06:29 Done, along with making the ctor protected.

: m_lifecycleContext(nullptr)

{

+ setContext(context);

}

#if !ENABLE(OILPAN)

« Source/platform/LifecycleNotifier.h ('K') | « Source/platform/LifecycleNotifier.h ('k') | no next file » | no next file with comments »