Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: Source/core/page/PageLifecycleObserver.h

Issue 1024543004: Disallow adding ContextLifecycleObservers during iteration. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: tidier LifecycleObserver ctor Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 1
2 /* 2 /*
3 * Copyright (C) 2013 Google Inc. All Rights Reserved. 3 * Copyright (C) 2013 Google Inc. All Rights Reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 26 matching lines...) Expand all
37 class PageLifecycleNotifier; 37 class PageLifecycleNotifier;
38 38
39 class CORE_EXPORT PageLifecycleObserver : public LifecycleObserver<Page, PageLif ecycleObserver, PageLifecycleNotifier> { 39 class CORE_EXPORT PageLifecycleObserver : public LifecycleObserver<Page, PageLif ecycleObserver, PageLifecycleNotifier> {
40 public: 40 public:
41 virtual void pageVisibilityChanged() { } 41 virtual void pageVisibilityChanged() { }
42 virtual void didCommitLoad(LocalFrame*) { } 42 virtual void didCommitLoad(LocalFrame*) { }
43 43
44 Page* page() const { return lifecycleContext(); } 44 Page* page() const { return lifecycleContext(); }
45 45
46 protected: 46 protected:
47 explicit PageLifecycleObserver(Page*); 47 explicit PageLifecycleObserver(Page* page)
48 : LifecycleObserver(page)
49 {
50 }
51
48 }; 52 };
49 53
50 } // namespace blink 54 } // namespace blink
51 55
52 #endif // PageLifecycleObserver_h 56 #endif // PageLifecycleObserver_h
OLDNEW
« no previous file with comments | « Source/core/frame/FrameDestructionObserver.cpp ('k') | Source/core/page/PageLifecycleObserver.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698