Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: Source/core/dom/ContextLifecycleObserver.h

Issue 1024543004: Disallow adding ContextLifecycleObservers during iteration. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: tidier LifecycleObserver ctor Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 29 matching lines...) Expand all
40 ExecutionContext* executionContext() const { return lifecycleContext(); } 40 ExecutionContext* executionContext() const { return lifecycleContext(); }
41 41
42 enum Type { 42 enum Type {
43 GenericType, 43 GenericType,
44 ActiveDOMObjectType, 44 ActiveDOMObjectType,
45 }; 45 };
46 46
47 Type observerType() const { return m_observerType; } 47 Type observerType() const { return m_observerType; }
48 48
49 protected: 49 protected:
50 explicit ContextLifecycleObserver(ExecutionContext*, Type = GenericType); 50 explicit ContextLifecycleObserver(ExecutionContext* executionContext, Type t ype = GenericType)
51 : LifecycleObserver(executionContext)
52 , m_observerType(type)
53 {
54 }
51 55
52 private: 56 private:
53 Type m_observerType; 57 Type m_observerType;
54 }; 58 };
55 59
56 } // namespace blink 60 } // namespace blink
57 61
58 #endif // ContextLifecycleObserver_h 62 #endif // ContextLifecycleObserver_h
OLDNEW
« no previous file with comments | « Source/core/dom/ContextLifecycleNotifier.cpp ('k') | Source/core/dom/ContextLifecycleObserver.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698