Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1024543003: DevTools: hand over SW inspection to chrome://inspect upon request. (Closed)

Created:
5 years, 9 months ago by pfeldman
Modified:
5 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, kinuko+watch, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: hand over SW inspection to chrome://inspect upon request. BUG=463892 Committed: https://crrev.com/25d14cc790db3793d60cebbbcc917dde951c1dfb Cr-Commit-Position: refs/heads/master@{#321553}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comment addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M content/browser/devtools/protocol/service_worker_handler.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
pfeldman
5 years, 9 months ago (2015-03-19 17:14:27 UTC) #2
dgozman
https://codereview.chromium.org/1024543003/diff/1/content/browser/devtools/protocol/service_worker_handler.cc File content/browser/devtools/protocol/service_worker_handler.cc (right): https://codereview.chromium.org/1024543003/diff/1/content/browser/devtools/protocol/service_worker_handler.cc#newcode304 content/browser/devtools/protocol/service_worker_handler.cc:304: ReportWorkerTerminated(static_cast<ServiceWorkerDevToolsAgentHost*>(host)); Let's remove host from |attached_hosts_| right here, and ...
5 years, 9 months ago (2015-03-20 09:42:45 UTC) #3
pfeldman
https://codereview.chromium.org/1024543003/diff/1/content/browser/devtools/protocol/service_worker_handler.cc File content/browser/devtools/protocol/service_worker_handler.cc (right): https://codereview.chromium.org/1024543003/diff/1/content/browser/devtools/protocol/service_worker_handler.cc#newcode304 content/browser/devtools/protocol/service_worker_handler.cc:304: ReportWorkerTerminated(static_cast<ServiceWorkerDevToolsAgentHost*>(host)); On 2015/03/20 09:42:44, dgozman wrote: > Let's remove ...
5 years, 9 months ago (2015-03-20 10:05:25 UTC) #4
dgozman
lgtm
5 years, 9 months ago (2015-03-20 10:13:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024543003/20001
5 years, 9 months ago (2015-03-20 10:14:06 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-20 12:00:07 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 12:01:14 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/25d14cc790db3793d60cebbbcc917dde951c1dfb
Cr-Commit-Position: refs/heads/master@{#321553}

Powered by Google App Engine
This is Rietveld 408576698