Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1024493004: Plugin Power Saver: Record PPS UMAs only for users with PPS enabled. (Closed)

Created:
5 years, 9 months ago by tommycli
Modified:
5 years, 9 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver: Record PPS UMAs only for users with PPS enabled. Previously, we collected PPS UMAs across all users. We created a throttler and used it in a 'simulated' mode. Now that real PPS users exist, collect UMAs only on actual PPS users. This is accomplished by only creating a throttler when PPS is enabled. BUG=470731 Committed: https://crrev.com/db0458c20b2fd343ce4a5c86a6777795ae10479f Cr-Commit-Position: refs/heads/master@{#322462}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -22 lines) Patch
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/plugins/renderer/loadable_plugin_placeholder.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M content/public/renderer/plugin_instance_throttler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/plugin_instance_throttler_impl.h View 3 chunks +2 lines, -5 lines 0 comments Download
M content/renderer/pepper/plugin_instance_throttler_impl.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M content/renderer/pepper/plugin_instance_throttler_impl_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
tommycli
piman, thestig, bauerb: PTAL Not a big patch. Appreciate reviews.
5 years, 9 months ago (2015-03-26 00:26:22 UTC) #2
Bernhard Bauer
lgtm
5 years, 9 months ago (2015-03-26 09:27:48 UTC) #3
Lei Zhang
lgtm
5 years, 9 months ago (2015-03-26 18:26:18 UTC) #4
piman
lgtm
5 years, 9 months ago (2015-03-26 20:21:38 UTC) #5
tommycli
piman, thestig, bauerb: Thank you all for the quick reviews.
5 years, 9 months ago (2015-03-26 20:28:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024493004/20001
5 years, 9 months ago (2015-03-26 20:28:48 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-26 20:38:59 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 20:39:31 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/db0458c20b2fd343ce4a5c86a6777795ae10479f
Cr-Commit-Position: refs/heads/master@{#322462}

Powered by Google App Engine
This is Rietveld 408576698