Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1367)

Unified Diff: chrome/browser/extensions/extension_uninstall_dialog.cc

Issue 1024493003: [Extensions] Adjust field trial for reporting abuse on uninstall (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: inline strings Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_uninstall_dialog.cc
diff --git a/chrome/browser/extensions/extension_uninstall_dialog.cc b/chrome/browser/extensions/extension_uninstall_dialog.cc
index 3bdb476e1f31af5ad3319f477122c5a807180962..b805d037e00c0e8e8c1bc9ff842cd0d93429d2da 100644
--- a/chrome/browser/extensions/extension_uninstall_dialog.cc
+++ b/chrome/browser/extensions/extension_uninstall_dialog.cc
@@ -129,26 +129,8 @@ std::string ExtensionUninstallDialog::GetHeadingText() {
}
bool ExtensionUninstallDialog::ShouldShowReportAbuseCheckbox() const {
- static const char kExperimentName[] = "ExtensionUninstall.ReportAbuse";
- static const char kDefaultGroupName[] = "Default";
- static const char kShowCheckboxGroup[] = "ShowCheckbox";
-
- // Important: Only initialize the trial once.
- if (!base::FieldTrialList::Find(kExperimentName)) {
- // TODO(devlin): Turn on this field trial. See crbug.com/441377.
- scoped_refptr<base::FieldTrial> trial(
- base::FieldTrialList::FactoryGetFieldTrial(
- kExperimentName,
- 100, // Total probability.
- kDefaultGroupName,
- 2015, 7, 31, // End date.
- base::FieldTrial::ONE_TIME_RANDOMIZED,
- nullptr));
- trial->AppendGroup(kShowCheckboxGroup, 0);
- }
-
- return base::FieldTrialList::FindFullName(kExperimentName) ==
- kShowCheckboxGroup;
+ return base::FieldTrialList::FindFullName("ExtensionUninstall.ReportAbuse") ==
+ "ShowCheckbox";
}
void ExtensionUninstallDialog::HandleReportAbuse() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698