Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1024493003: [Extensions] Adjust field trial for reporting abuse on uninstall (Closed)

Created:
5 years, 9 months ago by Devlin
Modified:
5 years, 9 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Adjust field trial for reporting abuse on uninstall Experiments should be set up/defined on the Finch server, not in Chromium code. Remove the definition. BUG=441377 Committed: https://crrev.com/11fb1e7ebcfa6b1515e2bc4791135332d4076aaf Cr-Commit-Position: refs/heads/master@{#322253}

Patch Set 1 #

Patch Set 2 : inline strings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -20 lines) Patch
M chrome/browser/extensions/extension_uninstall_dialog.cc View 1 1 chunk +2 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Devlin
Ilya, sanity check?
5 years, 9 months ago (2015-03-25 20:47:09 UTC) #2
Ilya Sherman
I'd probably inline the string constants, but LGTM. Thanks :)
5 years, 9 months ago (2015-03-25 20:52:46 UTC) #3
Devlin
On 2015/03/25 20:52:46, Ilya Sherman wrote: > I'd probably inline the string constants, but LGTM. ...
5 years, 9 months ago (2015-03-25 20:55:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024493003/20001
5 years, 9 months ago (2015-03-25 22:40:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-25 22:45:46 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 22:46:50 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/11fb1e7ebcfa6b1515e2bc4791135332d4076aaf
Cr-Commit-Position: refs/heads/master@{#322253}

Powered by Google App Engine
This is Rietveld 408576698