Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1024473005: Try out operator overloads for Sk2x. (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
mtklein, caryclark, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Try out operator overloads for Sk2x. BUG=skia: Committed: https://skia.googlesource.com/skia/+/d800d878caae5d25b275d488a1b5ae8c24cea492

Patch Set 1 #

Patch Set 2 : single expr #

Patch Set 3 : simpler math #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M src/core/Sk2x.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/core/SkGeometry.cpp View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M tests/Sk2xTest.cpp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mtklein_C
5 years, 9 months ago (2015-03-19 20:06:33 UTC) #2
caryclark
I find this much easier to read lgtm
5 years, 9 months ago (2015-03-19 20:42:32 UTC) #3
mtklein
Forgot to mention, I'll follow up with an analogous change to whatever we land here ...
5 years, 9 months ago (2015-03-19 20:44:35 UTC) #4
reed1
purty lgtm
5 years, 9 months ago (2015-03-19 21:11:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024473005/40001
5 years, 9 months ago (2015-03-19 21:21:28 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 21:28:41 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/d800d878caae5d25b275d488a1b5ae8c24cea492

Powered by Google App Engine
This is Rietveld 408576698