Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: content/renderer/media/media_stream_audio_processor_unittest.cc

Issue 1024473003: Disable crashing tests in MediaStreamAudioProcessorTest for Android ASAN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tot
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/media_stream_audio_processor_unittest.cc
diff --git a/content/renderer/media/media_stream_audio_processor_unittest.cc b/content/renderer/media/media_stream_audio_processor_unittest.cc
index 1dfa2c93cfad0a2049ce3bc87ca2a3dc67172854..bbdf794857c6a3b6ddb9c7b218dcbe38743a13a5 100644
--- a/content/renderer/media/media_stream_audio_processor_unittest.cc
+++ b/content/renderer/media/media_stream_audio_processor_unittest.cc
@@ -181,7 +181,13 @@ class MediaStreamAudioProcessorTest : public ::testing::Test {
media::AudioParameters params_;
};
-TEST_F(MediaStreamAudioProcessorTest, WithAudioProcessing) {
+// Test crashing with ASAN on Android. crbug.com/468762
+#if defined(OS_ANDROID) && defined(ADDRESS_SANITIZER)
+#define MAYBE_WithAudioProcessing DISABLED_WithAudioProcessing
+#else
+#define MAYBE_WithAudioProcessing WithAudioProcessing
+#endif
+TEST_F(MediaStreamAudioProcessorTest, MAYBE_WithAudioProcessing) {
MockMediaConstraintFactory constraint_factory;
scoped_refptr<WebRtcAudioDeviceImpl> webrtc_audio_device(
new WebRtcAudioDeviceImpl());
@@ -364,7 +370,13 @@ TEST_F(MediaStreamAudioProcessorTest, ValidateConstraints) {
EXPECT_FALSE(audio_constraints.IsValid());
}
-TEST_F(MediaStreamAudioProcessorTest, TestAllSampleRates) {
+// Test crashing with ASAN on Android. crbug.com/468762
+#if defined(OS_ANDROID) && defined(ADDRESS_SANITIZER)
+#define MAYBE_TestAllSampleRates DISABLED_TestAllSampleRates
+#else
+#define MAYBE_TestAllSampleRates TestAllSampleRates
+#endif
+TEST_F(MediaStreamAudioProcessorTest, MAYBE_TestAllSampleRates) {
MockMediaConstraintFactory constraint_factory;
scoped_refptr<WebRtcAudioDeviceImpl> webrtc_audio_device(
new WebRtcAudioDeviceImpl());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698