Issue 1024463010: Drop gLibCleanupFunctions from the TSAN suppression list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1024463010: Drop gLibCleanupFunctions from the TSAN suppression list (Closed)

Created:
5 years, 9 months ago by jungshik at Google

Modified:
5 years, 9 months ago

Reviewers:
Jeffrey Yasskin

CC:
chromium-reviews, earthdok, Alexander Potapenko

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Drop gLibCleanupFunctions from the TSAN suppression list ICU 54 fixed this issue. (see http://bugs.icu-project.org/trac/ticket/10295 ) BUG=270037 TEST=TSAN build of unit_tests --gtest_filter=*ShorterUR* Committed: https://crrev.com/b9f9b185b2ffd12245d338da0c57e2b45de0b4d8 Cr-Commit-Position: refs/heads/master@{#322097}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	build/sanitizers/tsan_suppressions.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 7 (2 generated)

Jeffrey Yasskin

LGTM, but adding the current valgrind sheriffs so they know what's up if this breaks ...

5 years, 9 months ago (2015-03-24 21:09:58 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024463010/1

5 years, 9 months ago (2015-03-24 22:22:29 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-24 23:58:25 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b9f9b185b2ffd12245d338da0c57e2b45de0b4d8
Cr-Commit-Position: refs/heads/master@{#322097}