Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Unified Diff: content/browser/notifications/platform_notification_context_unittest.cc

Issue 1024463006: Destroy the notification database when corruption occurs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@n-db-SWContextObserver
Patch Set: rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/notifications/platform_notification_context_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/notifications/platform_notification_context_unittest.cc
diff --git a/content/browser/notifications/platform_notification_context_unittest.cc b/content/browser/notifications/platform_notification_context_unittest.cc
index fde53f4fd822e7b13ff746e94f6d89f989ea9272..fc088c698d2b521098541b233038c18fae4bcdcf 100644
--- a/content/browser/notifications/platform_notification_context_unittest.cc
+++ b/content/browser/notifications/platform_notification_context_unittest.cc
@@ -3,6 +3,8 @@
// found in the LICENSE file.
#include "base/bind.h"
+#include "base/files/file_util.h"
+#include "base/files/scoped_temp_dir.h"
#include "base/run_loop.h"
#include "content/browser/notifications/platform_notification_context_impl.h"
#include "content/browser/service_worker/embedded_worker_test_helper.h"
@@ -281,4 +283,73 @@ TEST_F(PlatformNotificationContextTest, ServiceWorkerUnregistered) {
EXPECT_FALSE(success());
}
+TEST_F(PlatformNotificationContextTest, DestroyDatabaseOnStorageWiped) {
+ scoped_refptr<PlatformNotificationContextImpl> context =
+ CreatePlatformNotificationContext();
+
+ GURL origin("https://example.com");
+ NotificationDatabaseData notification_database_data;
+
+ context->WriteNotificationData(
+ origin,
+ notification_database_data,
+ base::Bind(&PlatformNotificationContextTest::DidWriteNotificationData,
+ base::Unretained(this)));
+
+ base::RunLoop().RunUntilIdle();
+
+ // The write operation should have succeeded with a notification id.
+ ASSERT_TRUE(success());
+ EXPECT_GT(notification_id(), 0);
+
+ // Call the OnStorageWiped override from the ServiceWorkerContextObserver,
+ // which indicates that the database should go away entirely.
+ context->OnStorageWiped();
+
+ // Verify that reading notification data fails because the data does not
+ // exist anymore. Deliberately omit RunUntilIdle(), since this is unlikely to
+ // be the case when OnStorageWiped gets called in production.
+ context->ReadNotificationData(
+ notification_id(),
+ origin,
+ base::Bind(&PlatformNotificationContextTest::DidReadNotificationData,
+ base::Unretained(this)));
+
+ base::RunLoop().RunUntilIdle();
+
+ EXPECT_FALSE(success());
+}
+
+TEST_F(PlatformNotificationContextTest, DestroyOnDiskDatabase) {
+ base::ScopedTempDir database_dir;
+ ASSERT_TRUE(database_dir.CreateUniqueTempDir());
+
+ // Manually construct the PlatformNotificationContextImpl because this test
+ // requires the database to be created on the filesystem.
+ scoped_refptr<PlatformNotificationContextImpl> context(
+ new PlatformNotificationContextImpl(database_dir.path(), nullptr));
+
+ OverrideTaskRunnerForTesting(context.get());
+
+ // Trigger a read-operation to force creating the database.
+ context->ReadNotificationData(
+ 42 /* notification_id */,
+ GURL("https://example.com"),
+ base::Bind(&PlatformNotificationContextTest::DidReadNotificationData,
+ base::Unretained(this)));
+
+ base::RunLoop().RunUntilIdle();
+
+ EXPECT_FALSE(IsDirectoryEmpty(database_dir.path()));
+ EXPECT_FALSE(success());
+
+ // Blow away the database by faking a Service Worker Context wipe-out.
+ context->OnStorageWiped();
+
+ base::RunLoop().RunUntilIdle();
+
+ // The database's directory should be empty at this point.
+ EXPECT_TRUE(IsDirectoryEmpty(database_dir.path()));
+}
+
} // namespace content
« no previous file with comments | « content/browser/notifications/platform_notification_context_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698