Destroy the notification database when corruption occurs.

content/browser/notifications/platform_notification_context_unittest.cc

Index: content/browser/notifications/platform_notification_context_unittest.cc
diff --git a/content/browser/notifications/platform_notification_context_unittest.cc b/content/browser/notifications/platform_notification_context_unittest.cc
index fa0e2491f4a47a61b38c7ae74f2757fa3c440d21..8a497657ebb2643e2b5f66378aac54d3d4103b7f 100644
--- a/content/browser/notifications/platform_notification_context_unittest.cc
+++ b/content/browser/notifications/platform_notification_context_unittest.cc
@@ -3,6 +3,8 @@
 // found in the LICENSE file.
 
 #include "base/bind.h"
+#include "base/files/file_util.h"
+#include "base/files/scoped_temp_dir.h"
 #include "base/run_loop.h"
 #include "content/browser/notifications/platform_notification_context_impl.h"
 #include "content/browser/service_worker/embedded_worker_test_helper.h"
@@ -279,4 +281,72 @@ TEST_F(PlatformNotificationContextTest, ServiceWorkerUnregistered) {
   EXPECT_FALSE(success());
 }
 
+TEST_F(PlatformNotificationContextTest, DestroyDatabaseOnStorageWiped) {
+  scoped_refptr<PlatformNotificationContextImpl> context =
+      CreatePlatformNotificationContext();
+
+  GURL origin("https://example.com");
+  NotificationDatabaseData notification_database_data;
+
+  context->WriteNotificationData(
+      origin,
+      notification_database_data,
+      base::Bind(&PlatformNotificationContextTest::DidWriteNotificationData,
+                 base::Unretained(this)));
+
+  base::RunLoop().RunUntilIdle();

[johnme, 2015/03/20 15:29:06]

As in https://codereview.chromium.org/1014703007/, this smells flaky. I'll wait
and see what you reply there.

[Peter Beverloo, 2015/03/20 18:55:37]

As replied there - it's not flaky because they're the same thread :).

+
+  // The write operation should have succeeded with a notification id.
+  ASSERT_TRUE(success());
+  EXPECT_GT(notification_id(), 0);
+
+  // Call the OnStorageWiped override from the ServiceWorkerContextObserver,
+  // which indicates that the database should go away entirely.
+  context->OnStorageWiped();
+
+  // Verify that reading notification data fails because the data does not
+  // exist anymore. Deliberately omit RunUntilIdle(), since this is unlikely to
+  // be the case when OnStorageWiped gets called in production.
+  context->ReadNotificationData(
+      notification_id(),
+      origin,
+      base::Bind(&PlatformNotificationContextTest::DidReadNotificationData,
+                 base::Unretained(this)));
+
+  base::RunLoop().RunUntilIdle();
+
+  EXPECT_FALSE(success());
+}
+
+TEST_F(PlatformNotificationContextTest, DestroyOnDiskDatabase) {
+  base::ScopedTempDir database_dir;
+  ASSERT_TRUE(database_dir.CreateUniqueTempDir());
+
+  // Manually construct the PlatformNotificationContextImpl because this test
+  // requires the database to be created on the filesystem.
+  scoped_refptr<PlatformNotificationContextImpl> context(
+      new PlatformNotificationContextImpl(database_dir.path(), nullptr));
+
+  OverrideTaskRunnerForTesting(context.get());
+
+  // Trigger a read-operation to force creating the database.
+  context->ReadNotificationData(
+      42 /* notification_id */,
+      GURL("https://example.com"),
+      base::Bind(&PlatformNotificationContextTest::DidReadNotificationData,
+                 base::Unretained(this)));
+
+  base::RunLoop().RunUntilIdle();
+
+  EXPECT_FALSE(success());
+
+  // Blow away the database by faking a Service Worker Context wipe-out.
+  context->OnStorageWiped();
+
+  base::RunLoop().RunUntilIdle();
+
+  // The database's directory should be empty at this point.
+  EXPECT_TRUE(IsDirectoryEmpty(database_dir.path()));

[johnme, 2015/03/20 15:29:06]

It's not immediately obvious that a read operation would write anything to disk.
Please add a corresponding EXPECT_FALSE(IsDirectoryEmpty(...)) above the
OnStorageWiped call.

[Peter Beverloo, 2015/03/20 18:55:37]

Done.

+}
+
 }  // namespace content