Added UMA metrics to track errors while launching lowbox enabled sandboxed process.

Added UMA metrics to track errors while launching lowbox enabled sandboxed process.

BUG=468919, 468922
R=cpu,jschuh@chromium.org,isherman@chromium.org

Committed: https://crrev.com/d60174a44fd5e8c8cc08946112d0ec823028d15e
Cr-Commit-Position: refs/heads/master@{#321633}

[Ilya Sherman, 2015-03-19 21:35:11]

https://codereview.chromium.org/1024463005/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1024463005/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:28899: +<histogram
name="Process.Sandbox.Lowbox.Launch.Error" units="GetLastError">
Please associate an enum rather than just writing "GetLastError" in the units. 
The enum doesn't have to be comprehensive; but if it isn't, please include a
link to where uncovered errors can be decoded.

[Shrikant Kelkar, 2015-03-19 21:40:50]

https://codereview.chromium.org/1024463005/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1024463005/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:28899: +<histogram
name="Process.Sandbox.Lowbox.Launch.Error" units="GetLastError">
On 2015/03/19 21:35:11, Ilya Sherman wrote:
> Please associate an enum rather than just writing "GetLastError" in the units.

> The enum doesn't have to be comprehensive; but if it isn't, please include a
> link to where uncovered errors can be decoded.

We don't know what is range of error values here. I can include link to decode
values though
(https://msdn.microsoft.com/en-us/library/windows/desktop/ms681381(v=vs.85).aspx)
and there is possibility that the error doesn't fall in documented error codes
in this particular situation as the API is new. Wondering if I should still use
enums vs units? I used units="GetLastError" following example of
PlatformFile.UnknownErrors.Windows.

[Ilya Sherman, 2015-03-19 21:43:08]

LGTM w/ comment addressed

https://codereview.chromium.org/1024463005/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1024463005/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:28899: +<histogram
name="Process.Sandbox.Lowbox.Launch.Error" units="GetLastError">
Please associate an enum rather than just writing "GetLastError" in the units. 
The enum doesn't have to be comprehensive; but if it isn't, please include a
link to where uncovered errors can be decoded.

https://codereview.chromium.org/1024463005/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:28899: +<histogram
name="Process.Sandbox.Lowbox.Launch.Error" units="GetLastError">
On 2015/03/19 21:40:50, Shrikant Kelkar wrote:
> On 2015/03/19 21:35:11, Ilya Sherman wrote:
> > Please associate an enum rather than just writing "GetLastError" in the
units.
> 
> > The enum doesn't have to be comprehensive; but if it isn't, please include a
> > link to where uncovered errors can be decoded.
> 
> We don't know what is range of error values here. I can include link to decode
> values though
>
(https://msdn.microsoft.com/en-us/library/windows/desktop/ms681381(v=vs.85).aspx)
> and there is possibility that the error doesn't fall in documented error codes
> in this particular situation as the API is new. Wondering if I should still
use
> enums vs units? I used units="GetLastError" following example of
> PlatformFile.UnknownErrors.Windows.

I see -- there are a *ton* of possible error messages.  Okay, in that case,
please just include a link to the list.  Thanks.

[Shrikant Kelkar, 2015-03-19 21:50:27]

On 2015/03/19 21:43:08, Ilya Sherman wrote:
> LGTM w/ comment addressed
> 
>
https://codereview.chromium.org/1024463005/diff/1/tools/metrics/histograms/hi...
> File tools/metrics/histograms/histograms.xml (right):
> 
>
https://codereview.chromium.org/1024463005/diff/1/tools/metrics/histograms/hi...
> tools/metrics/histograms/histograms.xml:28899: +<histogram
> name="Process.Sandbox.Lowbox.Launch.Error" units="GetLastError">
> Please associate an enum rather than just writing "GetLastError" in the units.

> The enum doesn't have to be comprehensive; but if it isn't, please include a
> link to where uncovered errors can be decoded.
> 
>
https://codereview.chromium.org/1024463005/diff/1/tools/metrics/histograms/hi...
> tools/metrics/histograms/histograms.xml:28899: +<histogram
> name="Process.Sandbox.Lowbox.Launch.Error" units="GetLastError">
> On 2015/03/19 21:40:50, Shrikant Kelkar wrote:
> > On 2015/03/19 21:35:11, Ilya Sherman wrote:
> > > Please associate an enum rather than just writing "GetLastError" in the
> units.
> > 
> > > The enum doesn't have to be comprehensive; but if it isn't, please include
a
> > > link to where uncovered errors can be decoded.
> > 
> > We don't know what is range of error values here. I can include link to
decode
> > values though
> >
>
(https://msdn.microsoft.com/en-us/library/windows/desktop/ms681381(v=vs.85).aspx)
> > and there is possibility that the error doesn't fall in documented error
codes
> > in this particular situation as the API is new. Wondering if I should still
> use
> > enums vs units? I used units="GetLastError" following example of
> > PlatformFile.UnknownErrors.Windows.
> 
> I see -- there are a *ton* of possible error messages.  Okay, in that case,
> please just include a link to the list.  Thanks.

Done.

[cpu_(ooo_6.6-7.5), 2015-03-20 19:26:54]

lgtm

[Shrikant Kelkar, 2015-03-20 19:27:16]

The CQ bit was checked by shrikant@chromium.org

[Shrikant Kelkar, 2015-03-20 19:27:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1024463005/#ps20001
(title: "Added link to MSDN GetLastError error codes.")

[commit-bot: I haz the power, 2015-03-20 19:27:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1024463005/20001

[commit-bot: I haz the power, 2015-03-20 20:59:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-20 21:00:34]

Patchset 2 (id:??) landed as
https://crrev.com/d60174a44fd5e8c8cc08946112d0ec823028d15e
Cr-Commit-Position: refs/heads/master@{#321633}