Upstream ios/testing

Upstream ios/testing

Upstreams the ios/testing directory, which contains a helper utility
for validating non-ObjC parameters in tests using OCMock.

BUG=None

Committed: https://crrev.com/9c337fc9eb6f0f5bdd012e742de5f247b3c8d489
Cr-Commit-Position: refs/heads/master@{#321583}

[stuartmorgan, 2015-03-19 04:56:27]

stuartmorgan@chromium.org changed reviewers:
+ eugenebut@chromium.org, rsesek@chromium.org

[stuartmorgan, 2015-03-19 04:56:28]

rsesek for the DEPS additions on third_party bits
eugenebut for the general upstreaming

This is straight upstreaming, except that I clang-formatted it and
fixed/modernized some ivars.

[Robert Sesek, 2015-03-19 14:06:48]

Did you consider putting this into //third_party/ocmock? I guess that would
require you to make OCMock depend on GTM, though…

[stuartmorgan, 2015-03-19 15:17:22]

On 2015/03/19 14:06:48, Robert Sesek wrote:
> Did you consider putting this into //third_party/ocmock? I guess that would
> require you to make OCMock depend on GTM, though…

Since it's not an extension of OCMock itself, just a stand-alone utility class
that helps adapt it for use in certain kinds of tests, it didn't seem like it
fit in the ocmock directory.

[Robert Sesek, 2015-03-19 16:37:51]

DEPS LGTM

[Eugene But (OOO till 7-30), 2015-03-20 16:26:57]

lgtm

https://codereview.chromium.org/1024443002/diff/1/ios/testing/ocmock_complex_...
File ios/testing/ocmock_complex_type_helper.h (right):

https://codereview.chromium.org/1024443002/diff/1/ios/testing/ocmock_complex_...
ios/testing/ocmock_complex_type_helper.h:9: 
NIT: do you need a linebreak here?

https://codereview.chromium.org/1024443002/diff/1/ios/testing/ocmock_complex_...
ios/testing/ocmock_complex_type_helper.h:18: -
(id)initWithRepresentedObject:(id)object;
NIT: s/id/instancetype

https://codereview.chromium.org/1024443002/diff/1/ios/testing/ocmock_complex_...
File ios/testing/ocmock_complex_type_helper.mm (right):

https://codereview.chromium.org/1024443002/diff/1/ios/testing/ocmock_complex_...
ios/testing/ocmock_complex_type_helper.mm:11: @private
No need for @private

https://codereview.chromium.org/1024443002/diff/1/ios/testing/ocmock_complex_...
ios/testing/ocmock_complex_type_helper.mm:20: -
(id)initWithRepresentedObject:(id)object {
NIT: s/id/instancetype

https://codereview.chromium.org/1024443002/diff/1/ios/testing/ocmock_complex_...
File ios/testing/ocmock_complex_type_helper_unittest.mm (right):

https://codereview.chromium.org/1024443002/diff/1/ios/testing/ocmock_complex_...
ios/testing/ocmock_complex_type_helper_unittest.mm:50: virtual void SetUp() {
NIT: void SetUp() override

https://codereview.chromium.org/1024443002/diff/1/ios/testing/ocmock_complex_...
ios/testing/ocmock_complex_type_helper_unittest.mm:57: virtual void TearDown() {
ditto

[stuartmorgan, 2015-03-20 16:31:43]

https://codereview.chromium.org/1024443002/diff/1/ios/testing/ocmock_complex_...
File ios/testing/ocmock_complex_type_helper.h (right):

https://codereview.chromium.org/1024443002/diff/1/ios/testing/ocmock_complex_...
ios/testing/ocmock_complex_type_helper.h:9: 
On 2015/03/20 16:26:56, eugenebut wrote:
> NIT: do you need a linebreak here?

Removed, and fixed ordering

https://codereview.chromium.org/1024443002/diff/1/ios/testing/ocmock_complex_...
ios/testing/ocmock_complex_type_helper.h:18: -
(id)initWithRepresentedObject:(id)object;
On 2015/03/20 16:26:57, eugenebut wrote:
> NIT: s/id/instancetype

Done.

https://codereview.chromium.org/1024443002/diff/1/ios/testing/ocmock_complex_...
File ios/testing/ocmock_complex_type_helper.mm (right):

https://codereview.chromium.org/1024443002/diff/1/ios/testing/ocmock_complex_...
ios/testing/ocmock_complex_type_helper.mm:11: @private
On 2015/03/20 16:26:57, eugenebut wrote:
> No need for @private

Done.

https://codereview.chromium.org/1024443002/diff/1/ios/testing/ocmock_complex_...
ios/testing/ocmock_complex_type_helper.mm:20: -
(id)initWithRepresentedObject:(id)object {
On 2015/03/20 16:26:57, eugenebut wrote:
> NIT: s/id/instancetype

Done.

https://codereview.chromium.org/1024443002/diff/1/ios/testing/ocmock_complex_...
File ios/testing/ocmock_complex_type_helper_unittest.mm (right):

https://codereview.chromium.org/1024443002/diff/1/ios/testing/ocmock_complex_...
ios/testing/ocmock_complex_type_helper_unittest.mm:50: virtual void SetUp() {
On 2015/03/20 16:26:57, eugenebut wrote:
> NIT: void SetUp() override

Done.

https://codereview.chromium.org/1024443002/diff/1/ios/testing/ocmock_complex_...
ios/testing/ocmock_complex_type_helper_unittest.mm:57: virtual void TearDown() {
On 2015/03/20 16:26:57, eugenebut wrote:
> ditto

Done.

[stuartmorgan, 2015-03-20 16:32:01]

The CQ bit was checked by stuartmorgan@chromium.org

[stuartmorgan, 2015-03-20 16:32:02]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/1024443002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2015-03-20 16:32:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1024443002/20001

[commit-bot: I haz the power, 2015-03-20 16:56:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-20 16:56:34]

Patchset 2 (id:??) landed as
https://crrev.com/9c337fc9eb6f0f5bdd012e742de5f247b3c8d489
Cr-Commit-Position: refs/heads/master@{#321583}