Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 1024383003: Revert of ServiceWorker: Support includeUncontrolled option in clients.matchAll() (1/2, chromium) (Closed)

Created:
5 years, 9 months ago by alph
Modified:
5 years, 9 months ago
Reviewers:
kinuko, nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ServiceWorker: Support includeUncontrolled option in clients.matchAll() (1/2, chromium) (patchset #4 id:120001 of https://codereview.chromium.org/1007133002/) Reason for revert: Broke http/tests/serviceworker/chromium/clients-openwindow.html http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/45800 Original issue's description: > ServiceWorker: Support includeUncontrolled option in clients.matchAll() (1/2, chromium) > > * Add SWContextCore::GetProviderHostByClientID() method > * Add SWContextCore::GetProviderHostIterator() which takes predicate > * Make ServiceWorkerVersion::OnGetClients return uncontrolled host when specified > * Make ServiceWorkerVersion::On{PostMessage,Focus} work for uncontrolled hosts > (i.e. now ServiceWorker can have clients that are not controlled by it) > > Spec links: > https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#serviceworker-client-query-options-dictionary > https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#clients-getall > > 1/2: THIS PATCH > 2/2: blink patch (layout tests will be added here) > > BUG=460415 > TEST=ServiceWorkerContextTest.GetProviderHostIterator > TEST=layout tests will be added later > > Committed: https://crrev.com/04848e8f57c823b674b0a3e03047e281fae44bfd > Cr-Commit-Position: refs/heads/master@{#321722} TBR=nhiroki@chromium.org,kinuko@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=460415 Committed: https://crrev.com/dec2cd69cca6346089eee3c2110d9d3518e3b3d4 Cr-Commit-Position: refs/heads/master@{#321749}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -182 lines) Patch
M content/browser/service_worker/service_worker_context_core.h View 3 chunks +6 lines, -18 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.cc View 7 chunks +10 lines, -44 lines 0 comments Download
M content/browser/service_worker/service_worker_context_unittest.cc View 2 chunks +0 lines, -75 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 4 chunks +29 lines, -41 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
alph
Created Revert of ServiceWorker: Support includeUncontrolled option in clients.matchAll() (1/2, chromium)
5 years, 9 months ago (2015-03-23 09:37:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024383003/1
5 years, 9 months ago (2015-03-23 09:38:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 09:38:39 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dec2cd69cca6346089eee3c2110d9d3518e3b3d4 Cr-Commit-Position: refs/heads/master@{#321749}
5 years, 9 months ago (2015-03-23 09:39:17 UTC) #4
kinuko
Um... was about to update the test expectations (https://codereview.chromium.org/1028063002/). Thanks anyways.
5 years, 9 months ago (2015-03-23 09:40:02 UTC) #5
alph
On 2015/03/23 09:40:02, kinuko wrote: > Um... was about to update the test expectations > ...
5 years, 9 months ago (2015-03-23 09:57:10 UTC) #6
kinuko
5 years, 9 months ago (2015-03-23 13:40:44 UTC) #7
Message was sent while issue was closed.
On 2015/03/23 09:57:10, alph wrote:
> On 2015/03/23 09:40:02, kinuko wrote:
> > Um... was about to update the test expectations
> > (https://codereview.chromium.org/1028063002/).  Thanks anyways.
> 
> Sorry, it was 9 hours since landing. So I thought nobody's looking at it.

Yup, np, thanks!

Powered by Google App Engine
This is Rietveld 408576698