Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 1024363002: [Mac] Restore the Chrome main menu if there are no windows on the active space. (Closed)

Created:
5 years, 9 months ago by jackhou1
Modified:
5 years, 9 months ago
Reviewers:
tapted
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Restore the Chrome main menu if there are no windows on the active space. When an app window closes, we skip restoring the Chrome main menu if there are other windows to minimize the number of times the main menu is changed. This doesn't work if the other windows are on different spaces. This ensures the Chrome menu is restored if there are no other windows on the active space. BUG=467323 Committed: https://crrev.com/0c169fe7fcece6e098fab9902d75d4fe91555843 Cr-Commit-Position: refs/heads/master@{#322495}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jackhou1
tapted, could you take a look?
5 years, 9 months ago (2015-03-23 01:56:40 UTC) #2
tapted
lgtm! Sorry for the delay
5 years, 9 months ago (2015-03-26 19:01:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024363002/1
5 years, 9 months ago (2015-03-26 22:41:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 23:31:34 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 23:32:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c169fe7fcece6e098fab9902d75d4fe91555843
Cr-Commit-Position: refs/heads/master@{#322495}

Powered by Google App Engine
This is Rietveld 408576698