Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1024343002: Revert "remove -Wno-header-guard workaround for old versions of NSS" (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "remove -Wno-header-guard workaround for old versions of NSS" This reverts commit 86ebf48be903b226d068b08efa16fe3725babb8c. Build failures: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder/builds/20027 http://build.chromium.org/p/chromium.webkit/builders/GPU%20Linux%20Builder%20%28dbg%29/builds/31334 Original issue's description: > remove -Wno-header-guard workaround for old versions of NSS > > I think it's safe to re-enable this warning now. The bug was > fixed upstream in 3.15.1 and there have been several NSS upgrades since then. > > BUG=255201 > Committed: https://crrev.com/86ebf48be903b226d068b08efa16fe3725babb8c > Cr-Commit-Position: refs/heads/master@{#321711} TBR=mostynb@opera.com,thakis@chromium.org BUG=255201 NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/7e9611ced1805c43af09fccc03367313e5253ca9 Cr-Commit-Position: refs/heads/master@{#321712}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M build/linux/system.gyp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
ptal
5 years, 9 months ago (2015-03-22 11:23:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024343002/1
5 years, 9 months ago (2015-03-22 11:24:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-22 11:24:38 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7e9611ced1805c43af09fccc03367313e5253ca9 Cr-Commit-Position: refs/heads/master@{#321712}
5 years, 9 months ago (2015-03-22 11:25:29 UTC) #6
Mostyn Bramley-Moore
5 years, 9 months ago (2015-03-22 17:31:28 UTC) #7
Message was sent while issue was closed.
LGTM.  Thanks for reverting this.

Powered by Google App Engine
This is Rietveld 408576698