Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 102433010: prerender: Add NavigationOrSwapObserver in browsertest. (Closed)

Created:
6 years, 11 months ago by davidben
Modified:
6 years, 11 months ago
Reviewers:
mmenke
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, davidben+watch_chromium.org
Visibility:
Public.

Description

prerender: Add NavigationOrSwapObserver in browsertest. Prerender browser tests are currently sensitive to prerenders occurring synchronously. Already we require an ad-hoc content::RunMessageLoop() in PrerenderPageNewTab because that one is asynchronous. Instead, introduce a NavigationOrSwapObserver so NavigateToURL always waits for either the swap or a normal navigation. This allows removing the content::RunMessageLoop() call and is necessary for fixing beforeunload handling. Also split off DidDisplayPass and DidPrerenderPass into helper functions. BUG=307592, 304932 TEST=PrerenderBrowserTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243616

Patch Set 1 #

Total comments: 15

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -36 lines) Patch
M chrome/browser/prerender/prerender_browsertest.cc View 1 14 chunks +110 lines, -36 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
davidben
Splitting this part out of the resource throttle prerender CL. Less to review and this'll ...
6 years, 11 months ago (2014-01-07 14:49:11 UTC) #1
mmenke
Just nits, LGTM! And nice and small enough to be an easy review - much ...
6 years, 11 months ago (2014-01-07 15:09:17 UTC) #2
davidben
Revised description. Also fixed build on some of the bots. https://codereview.chromium.org/102433010/diff/1/chrome/browser/prerender/prerender_browsertest.cc File chrome/browser/prerender/prerender_browsertest.cc (right): https://codereview.chromium.org/102433010/diff/1/chrome/browser/prerender/prerender_browsertest.cc#newcode245 ...
6 years, 11 months ago (2014-01-07 17:31:33 UTC) #3
mmenke
Still LGTM. https://codereview.chromium.org/102433010/diff/1/chrome/browser/prerender/prerender_browsertest.cc File chrome/browser/prerender/prerender_browsertest.cc (right): https://codereview.chromium.org/102433010/diff/1/chrome/browser/prerender/prerender_browsertest.cc#newcode245 chrome/browser/prerender/prerender_browsertest.cc:245: if (old_contents != web_contents()) On 2014/01/07 17:31:34, ...
6 years, 11 months ago (2014-01-07 17:44:49 UTC) #4
davidben
https://codereview.chromium.org/102433010/diff/1/chrome/browser/prerender/prerender_browsertest.cc File chrome/browser/prerender/prerender_browsertest.cc (right): https://codereview.chromium.org/102433010/diff/1/chrome/browser/prerender/prerender_browsertest.cc#newcode245 chrome/browser/prerender/prerender_browsertest.cc:245: if (old_contents != web_contents()) On 2014/01/07 17:44:50, mmenke wrote: ...
6 years, 11 months ago (2014-01-07 18:57:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/102433010/100001
6 years, 11 months ago (2014-01-07 19:03:19 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242658
6 years, 11 months ago (2014-01-07 21:00:53 UTC) #7
davidben
On 2014/01/07 21:00:53, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 11 months ago (2014-01-08 00:48:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/102433010/100001
6 years, 11 months ago (2014-01-08 00:51:40 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242959
6 years, 11 months ago (2014-01-08 03:41:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/102433010/100001
6 years, 11 months ago (2014-01-08 16:14:56 UTC) #11
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 18:52:25 UTC) #12
Message was sent while issue was closed.
Change committed as 243616

Powered by Google App Engine
This is Rietveld 408576698