Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6593)

Unified Diff: chrome/browser/resources/local_ntp/most_visited_util.js

Issue 102433009: Most visited iframe now postMessage to signal the iframing page that the link has been displayed (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed support for multiple thumbnail URLs, refactored UMA logging. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/local_ntp/most_visited_util.js
diff --git a/chrome/browser/resources/local_ntp/most_visited_util.js b/chrome/browser/resources/local_ntp/most_visited_util.js
index 5a17fbd10bfff9b4e35d23d64c78312cf3c70ac5..5a22d5fc76142a97ff0ce87b680f74594b388638 100644
--- a/chrome/browser/resources/local_ntp/most_visited_util.js
+++ b/chrome/browser/resources/local_ntp/most_visited_util.js
@@ -22,18 +22,24 @@ var NTP_LOGGING_EVENT_TYPE = {
// There was an error in loading both the thumbnail image and the fallback
// (if it was provided), resulting in a grey tile.
NTP_THUMBNAIL_ERROR: 2,
- // The page attempted to load a thumbnail URL while a fallback thumbnail was
- // provided.
- NTP_FALLBACK_THUMBNAIL_REQUESTED: 3,
- // The primary thumbnail image failed to load and caused us to use the
- // secondary thumbnail as a fallback.
- NTP_FALLBACK_THUMBNAIL_USED: 4,
+ // DEPRECATED: NTP_FALLBACK_THUMBNAIL_REQUESTED: 3,
Mathieu 2014/01/09 18:37:18 let's remove them?
beaudoin 2014/01/15 23:39:56 Done.
+ // DEPRECATED: NTP_FALLBACK_THUMBNAIL_USED_DEPRECATED: 4,
// The suggestion is coming from the server.
NTP_SERVER_SIDE_SUGGESTION: 5,
// The suggestion is coming from the client.
NTP_CLIENT_SIDE_SUGGESTION: 6,
// The visuals of that tile are handled externally by the page itself.
- NTP_EXTERNAL_TILE: 7
+ NTP_EXTERNAL_TILE: 7,
+ // Indicates a tile was rendered, no matter if it's a thumbnail, a gray tile
+ // or an external tile.
+ NTP_TILE: 8,
+ // Used when no thumbnail is specified and a gray tile with the domain is used
+ // as the main tile.
+ NTP_GRAY_TILE: 9,
+ // Used a gray tile with the domain as the fallback for a failed thumbnail.
+ NTP_GRAY_TILE_FALLBACK: 10,
+ // The visuals of that tile's fallback are handled externally.
+ NTP_EXTERNAL_FALLBACK: 11
};
/**

Powered by Google App Engine
This is Rietveld 408576698