Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5583)

Unified Diff: chrome/common/ntp_logging_events.h

Issue 102433009: Most visited iframe now postMessage to signal the iframing page that the link has been displayed (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding server0 to histogram.xml. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/ntp_logging_events.h
diff --git a/chrome/common/ntp_logging_events.h b/chrome/common/ntp_logging_events.h
index ebb213a1e5eac3de1bf4f9cb350f8d1f822aea19..1878b65fff2aae8f5a98c96a69fc83702dfd374e 100644
--- a/chrome/common/ntp_logging_events.h
+++ b/chrome/common/ntp_logging_events.h
@@ -7,32 +7,38 @@
// The different types of events that are logged from the NTP.
Alexei Svitkine (slow) 2014/01/16 19:50:30 Nit: Might be worth expanding the comment to menti
beaudoin 2014/01/17 03:51:46 Done.
enum NTPLoggingEventType {
- // The user moused over an NTP tile or title.
- NTP_MOUSEOVER = 0,
+ // The suggestion is coming from the server.
+ NTP_SERVER_SIDE_SUGGESTION = 0,
- // The page attempted to load a thumbnail image.
- NTP_THUMBNAIL_ATTEMPT = 1,
+ // The suggestion is coming from the client.
+ NTP_CLIENT_SIDE_SUGGESTION = 1,
- // There was an error in loading both the thumbnail image and the fallback
- // (if it was provided), resulting in a grey tile.
- NTP_THUMBNAIL_ERROR = 2,
+ // Indicates a tile was rendered, no matter if it's a thumbnail, a gray tile
+ // or an external tile.
+ NTP_TILE = 2,
- // The page attempted to load a thumbnail URL while a fallback thumbnail was
- // provided.
- NTP_FALLBACK_THUMBNAIL_REQUESTED = 3,
+ // The tile uses a local thumbnail image.
+ NTP_THUMBNAIL_TILE = 3,
- // The primary thumbnail image failed to load and caused us to use the
- // secondary thumbnail as a fallback.
- NTP_FALLBACK_THUMBNAIL_USED = 4,
+ // Used when no thumbnail is specified and a gray tile with the domain is used
+ // as the main tile.
+ NTP_GRAY_TILE = 4,
- // The suggestion is coming from the server.
- NTP_SERVER_SIDE_SUGGESTION = 5,
+ // The visuals of that tile are handled externally by the page itself.
+ NTP_EXTERNAL_TILE = 5,
- // The suggestion is coming from the client.
- NTP_CLIENT_SIDE_SUGGESTION = 6,
+ // There was an error in loading both the thumbnail image and the fallback
+ // (if it was provided), resulting in a grey tile.
+ NTP_THUMBNAIL_ERROR = 6,
- // The visuals of that tile are handled externally by the page itself.
- NTP_EXTERNAL_TILE = 7,
+ // Used a gray tile with the domain as the fallback for a failed thumbnail.
+ NTP_GRAY_TILE_FALLBACK = 7,
+
+ // The visuals of that tile's fallback are handled externally.
+ NTP_EXTERNAL_TILE_FALLBACK = 8,
+
+ // The user moused over an NTP tile or title.
+ NTP_MOUSEOVER = 9,
NTP_NUM_EVENT_TYPES
};

Powered by Google App Engine
This is Rietveld 408576698