Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2227)

Unified Diff: chrome/browser/resources/local_ntp/most_visited_util.js

Issue 102433009: Most visited iframe now postMessage to signal the iframing page that the link has been displayed (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding server0 to histogram.xml. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/local_ntp/most_visited_util.js
diff --git a/chrome/browser/resources/local_ntp/most_visited_util.js b/chrome/browser/resources/local_ntp/most_visited_util.js
index 5a17fbd10bfff9b4e35d23d64c78312cf3c70ac5..d371dd1c15f3d36d8b359ba4468e0799516b5fea 100644
--- a/chrome/browser/resources/local_ntp/most_visited_util.js
+++ b/chrome/browser/resources/local_ntp/most_visited_util.js
@@ -15,25 +15,29 @@
* @const
*/
var NTP_LOGGING_EVENT_TYPE = {
- // The user moused over an NTP tile or title.
- NTP_MOUSEOVER: 0,
- // The page attempted to load a thumbnail image.
- NTP_THUMBNAIL_ATTEMPT: 1,
- // There was an error in loading both the thumbnail image and the fallback
- // (if it was provided), resulting in a grey tile.
- NTP_THUMBNAIL_ERROR: 2,
- // The page attempted to load a thumbnail URL while a fallback thumbnail was
- // provided.
- NTP_FALLBACK_THUMBNAIL_REQUESTED: 3,
- // The primary thumbnail image failed to load and caused us to use the
- // secondary thumbnail as a fallback.
- NTP_FALLBACK_THUMBNAIL_USED: 4,
// The suggestion is coming from the server.
- NTP_SERVER_SIDE_SUGGESTION: 5,
+ NTP_SERVER_SIDE_SUGGESTION: 0,
// The suggestion is coming from the client.
- NTP_CLIENT_SIDE_SUGGESTION: 6,
+ NTP_CLIENT_SIDE_SUGGESTION: 1,
+ // Indicates a tile was rendered, no matter if it's a thumbnail, a gray tile
+ // or an external tile.
+ NTP_TILE: 2,
+ // The tile uses a local thumbnail image.
+ NTP_THUMBNAIL_TILE: 3,
+ // Used when no thumbnail is specified and a gray tile with the domain is used
+ // as the main tile.
+ NTP_GRAY_TILE: 4,
// The visuals of that tile are handled externally by the page itself.
- NTP_EXTERNAL_TILE: 7
+ NTP_EXTERNAL_TILE: 5,
+ // There was an error in loading both the thumbnail image and the fallback
+ // (if it was provided), resulting in a grey tile.
+ NTP_THUMBNAIL_ERROR: 6,
+ // Used a gray tile with the domain as the fallback for a failed thumbnail.
+ NTP_GRAY_TILE_FALLBACK: 7,
+ // The visuals of that tile's fallback are handled externally.
+ NTP_EXTERNAL_TILE_FALLBACK: 8,
+ // The user moused over an NTP tile or title.
+ NTP_MOUSEOVER: 9
};
/**

Powered by Google App Engine
This is Rietveld 408576698