Most visited iframe now postMessage to signal the iframing page that the link has been displayed

chrome/browser/ui/webui/ntp/ntp_user_data_logger.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_NTP_NTP_USER_DATA_LOGGER_H_
 #define CHROME_BROWSER_UI_WEBUI_NTP_NTP_USER_DATA_LOGGER_H_
 
+#include "base/gtest_prod_util.h"
 #include "chrome/common/ntp_logging_events.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/browser/web_contents_user_data.h"
 
 namespace content {
 class WebContents;
 }
 
 // Helper class for logging data from the NTP. Attached to each NTP instance.
 class NTPUserDataLogger
     : public content::WebContentsObserver,
       public content::WebContentsUserData<NTPUserDataLogger> {
  public:
   virtual ~NTPUserDataLogger();
 
   static NTPUserDataLogger* GetOrCreateFromWebContents(
       content::WebContents* content);
 
-  // Logs the error percentage rate when loading thumbnail images for this NTP
-  // session to UMA histogram. Called when the user navigates to a URL. Only
-  // called for the instant NTP.
-  void EmitThumbnailErrorRate();
-
   // Logs a number of statistics regarding the NTP. Called when an NTP tab is
   // about to be deactivated (be it by switching tabs, losing focus or closing
   // the tab/shutting down Chrome), or when the user navigates to a URL.
   void EmitNtpStatistics();
 
   // Called each time an event occurs on the NTP that requires a counter to be
   // incremented.
   void LogEvent(NTPLoggingEventType event);
 
   // Logs an impression on one of the Most Visited tiles by a given provider.
   void LogImpression(int position, const base::string16& provider);
 
   // content::WebContentsObserver override
   virtual void NavigationEntryCommitted(
       const content::LoadCommittedDetails& load_details) OVERRIDE;
 
  protected:
+  FRIEND_TEST_ALL_PREFIXES(NTPUserDataLoggerTest, TestLogging);

[Evan Stade, 2014/01/09 00:45:42]

if this is just for the constructor, I'd prefer you create a testing subclass
with a public constructor. FRIEND_TEST is annoying and leaks test code into
prod.

[beaudoin, 2014/01/15 23:39:56]

Done.

   explicit NTPUserDataLogger(content::WebContents* contents);
 
-  // Returns the percent error given |events| occurrences and |errors| errors.
-  virtual size_t GetPercentError(size_t errors, size_t events) const;
-
  private:
   friend class content::WebContentsUserData<NTPUserDataLogger>;
 
   // Total number of mouseovers for this NTP session.
   size_t number_of_mouseovers_;
 
+  // Total number of tiles rendered, no matter if it's a thumbnail, a gray tile
+  // or an external tile.
+  size_t number_of_tiles_;
+
   // Total number of attempts made to load thumbnail images for this NTP
   // session.
   size_t number_of_thumbnail_attempts_;
 
   // Total number of errors that occurred when trying to load thumbnail images
   // for this NTP session. When these errors occur a grey tile is shown instead
   // of a thumbnail image.
   size_t number_of_thumbnail_errors_;
 
-  // Total number of attempts made to load thumbnail images while providing a
-  // fallback thumbnail for this NTP session.
-  size_t number_of_fallback_thumbnails_requested_;
+  // The number of times a gray tile with the domain was used as the fallback
+  // for a failed thumbnail.
+  size_t number_of_gray_tile_fallbacks_;
 
-  // Total number of errors that occurred while trying to load the primary
-  // thumbnail image and that caused a fallback to the secondary thumbnail.
-  size_t number_of_fallback_thumbnails_used_;
+  // The number of times an external tile, for which the visual appearance is
+  // handled by the page itself, was the fallback for a failed thumbnail.
+  size_t number_of_external_fallbacks_;
 
   // Total number of tiles for which the visual appearance is handled externally
   // by the page itself.
   size_t number_of_external_tiles_;
 
+  // Total number of tiles for which no thumbnail is specified and a gray tile
+  // with the domain is used as the main tile.
+  size_t number_of_gray_tiles_;

[Evan Stade, 2014/01/09 00:45:42]

can you make the order of these member variables match the order in the enum

[beaudoin, 2014/01/15 23:39:56]

I cleaned the enums up, used more uniform names and reordered everything in a
consistant manner. My OCD-self is happy. :)

+
   // True if at least one iframe came from a server-side suggestion. In
   // practice, either all the iframes are server-side suggestions or none are.
   bool server_side_suggestions_;
 
   // The URL of this New Tab Page - varies based on NTP version.
   GURL ntp_url_;
 
   DISALLOW_COPY_AND_ASSIGN(NTPUserDataLogger);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBUI_NTP_NTP_USER_DATA_LOGGER_H_