Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Side by Side Diff: chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc

Issue 102433009: Most visited iframe now postMessage to signal the iframing page that the link has been displayed (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding server0 to histogram.xml. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/ntp/ntp_user_data_logger.h" 5 #include "chrome/browser/ui/webui/ntp/ntp_user_data_logger.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "testing/gmock/include/gmock/gmock.h" 8 #include "base/metrics/histogram.h"
9 #include "base/metrics/statistics_recorder.h"
10 #include "chrome/common/ntp_logging_events.h"
9 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
10 12
11 namespace { 13 namespace {
12 14
13 class MockNTPUserDataLogger : public NTPUserDataLogger { 15 class TestNTPUserDataLogger : public NTPUserDataLogger {
14 public: 16 public:
15 MockNTPUserDataLogger() : NTPUserDataLogger(NULL) {} 17 TestNTPUserDataLogger() : NTPUserDataLogger(NULL) {}
16 virtual ~MockNTPUserDataLogger() {} 18 virtual ~TestNTPUserDataLogger() {}
19 };
17 20
18 MOCK_CONST_METHOD2(GetPercentError, size_t(size_t errors, size_t events)); 21 base::HistogramBase::Count GetTotalCount(const std::string& histogram_name) {
22 base::HistogramBase* histogram = base::StatisticsRecorder::FindHistogram(
23 histogram_name);
24 return histogram->SnapshotSamples()->TotalCount();
25 }
19 26
20 private: 27 base::HistogramBase::Count GetBinCount(const std::string& histogram_name,
21 DISALLOW_COPY_AND_ASSIGN(MockNTPUserDataLogger); 28 base::HistogramBase::Sample value) {
22 }; 29 base::HistogramBase* histogram = base::StatisticsRecorder::FindHistogram(
30 histogram_name);
31 return histogram->SnapshotSamples()->GetCount(value);
32 }
23 33
24 } // namespace 34 } // namespace
25 35
26 TEST(NTPUserDataLoggerTest, ThumbnailErrorRateDoesNotDivideByZero) { 36 TEST(NTPUserDataLoggerTest, TestLogging) {
27 MockNTPUserDataLogger logger; 37 base::StatisticsRecorder::Initialize();
28 EXPECT_CALL(logger, GetPercentError(testing::_, testing::_)).Times(0); 38 TestNTPUserDataLogger logger;
29 logger.EmitThumbnailErrorRate(); 39
40 // Ensure it works when the statistics are all empty. Only the mouseover
41 // should be logged in this case. The other histograms are not created yet so
42 // we can't query them.
43 logger.EmitNtpStatistics();
44
45 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfMouseOvers"));
46 EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfMouseOvers", 0));
47
48 // Ensure it works with some non-zero statistics. All statistics should now
49 // be logged.
50 for (int i = 0; i < 20; ++i)
51 logger.LogEvent(NTP_MOUSEOVER);
52 for (int i = 0; i < 8; ++i)
53 logger.LogEvent(NTP_TILE);
54 for (int i = 0; i < 4; ++i)
55 logger.LogEvent(NTP_THUMBNAIL_TILE);
56 for (int i = 0; i < 2; ++i)
57 logger.LogEvent(NTP_THUMBNAIL_ERROR);
58 logger.LogEvent(NTP_GRAY_TILE_FALLBACK);
59 logger.LogEvent(NTP_EXTERNAL_TILE_FALLBACK);
60 for (int i = 0; i < 2; ++i)
61 logger.LogEven t(NTP_EXTERNAL_TILE);
62 for (int i = 0; i < 2; ++i)
63 logger.LogEvent(NTP_GRAY_TILE);
64 logger.LogEvent(NTP_SERVER_SIDE_SUGGESTION);
65 logger.EmitNtpStatistics();
66
67 EXPECT_EQ(2, GetTotalCount("NewTabPage.NumberOfMouseOvers"));
68 EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfMouseOvers", 0));
69 EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfMouseOvers", 20));
70 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfTiles"));
71 EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfTiles", 8));
72 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfThumbnailTiles"));
73 EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfThumbnailTiles", 4));
74 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfThumbnailErrors"));
75 EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfThumbnailErrors", 2));
76 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfGrayTileFallbacks"));
77 EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfGrayTileFallbacks", 1));
78 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfExternalTileFallbacks"));
79 EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfExternalTileFallbacks", 1));
80 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfExternalTiles"));
81 EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfExternalTiles", 2));
82 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfGrayTiles"));
83 EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfGrayTiles", 2));
84 EXPECT_EQ(1, GetTotalCount("NewTabPage.SuggestionsType"));
85 EXPECT_EQ(1, GetBinCount("NewTabPage.SuggestionsType", 1));
86
87 // Statistics should be reset to 0, so we should not log anything else.
88 logger.EmitNtpStatistics();
89 EXPECT_EQ(3, GetTotalCount("NewTabPage.NumberOfMouseOvers"));
90 EXPECT_EQ(2, GetBinCount("NewTabPage.NumberOfMouseOvers", 0));
91 EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfMouseOvers", 20));
92 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfTiles"));
93 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfThumbnailTiles"));
94 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfThumbnailErrors"));
95 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfGrayTileFallbacks"));
96 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfExternalTileFallbacks"));
97 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfExternalTiles"));
98 EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfGrayTiles"));
99 EXPECT_EQ(1, GetTotalCount("NewTabPage.SuggestionsType"));
30 } 100 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698