Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 102433002: [DevTools] Improved console.copy command to handle JSON.stringifyable objects. (Closed)

Created:
7 years ago by Dmitry Zvorygin
Modified:
7 years ago
Reviewers:
vsevik, aandrey, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

[DevTools] Improved console.copy command to handle JSON.stringifyable objects. BUG=289348 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163344

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed cornercases. Added more tests. #

Total comments: 4

Patch Set 3 : Fixed comments. #

Patch Set 4 : Fixed comments. #

Total comments: 1

Patch Set 5 : Drive-by patch becomes too complex, thus removing it. #

Total comments: 2

Patch Set 6 : Fixed indentation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -6 lines) Patch
M LayoutTests/inspector/console/console-command-copy.html View 1 2 3 4 5 1 chunk +21 lines, -3 lines 0 comments Download
M LayoutTests/inspector/console/console-command-copy-expected.txt View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
M Source/core/inspector/InjectedScriptSource.js View 1 1 chunk +13 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Dmitry Zvorygin
Please take a look.
7 years ago (2013-12-03 17:31:20 UTC) #1
pfeldman
There is no console.copy, you mean "copy" as a part of command line api https://codereview.chromium.org/102433002/diff/1/Source/core/inspector/InjectedScriptSource.js ...
7 years ago (2013-12-03 17:47:51 UTC) #2
aandrey
https://codereview.chromium.org/102433002/diff/1/Source/core/inspector/InjectedScriptSource.js File Source/core/inspector/InjectedScriptSource.js (right): https://codereview.chromium.org/102433002/diff/1/Source/core/inspector/InjectedScriptSource.js#newcode1393 Source/core/inspector/InjectedScriptSource.js:1393: string = JSON.stringify(object, null, " "); 1) string can ...
7 years ago (2013-12-03 17:49:41 UTC) #3
Dmitry Zvorygin
Please take a look. https://codereview.chromium.org/102433002/diff/1/Source/core/inspector/InjectedScriptSource.js File Source/core/inspector/InjectedScriptSource.js (right): https://codereview.chromium.org/102433002/diff/1/Source/core/inspector/InjectedScriptSource.js#newcode1389 Source/core/inspector/InjectedScriptSource.js:1389: } else if (typeof object ...
7 years ago (2013-12-04 11:12:48 UTC) #4
aandrey
lgtm (not owner) https://codereview.chromium.org/102433002/diff/20001/LayoutTests/inspector/console/console-command-copy.html File LayoutTests/inspector/console/console-command-copy.html (right): https://codereview.chromium.org/102433002/diff/20001/LayoutTests/inspector/console/console-command-copy.html#newcode24 LayoutTests/inspector/console/console-command-copy.html:24: InspectorTest.evaluateInConsole("copy(false)"); could you also add smth ...
7 years ago (2013-12-04 11:45:30 UTC) #5
pfeldman
https://codereview.chromium.org/102433002/diff/20001/LayoutTests/inspector/console/console-command-copy.html File LayoutTests/inspector/console/console-command-copy.html (right): https://codereview.chromium.org/102433002/diff/20001/LayoutTests/inspector/console/console-command-copy.html#newcode29 LayoutTests/inspector/console/console-command-copy.html:29: InspectorTest.completeTest(); Just place this into the callback of evaluateInConsole, ...
7 years ago (2013-12-04 11:48:56 UTC) #6
Dmitry Zvorygin
Please take a look. https://codereview.chromium.org/102433002/diff/20001/LayoutTests/inspector/console/console-command-copy.html File LayoutTests/inspector/console/console-command-copy.html (right): https://codereview.chromium.org/102433002/diff/20001/LayoutTests/inspector/console/console-command-copy.html#newcode24 LayoutTests/inspector/console/console-command-copy.html:24: InspectorTest.evaluateInConsole("copy(false)"); On 2013/12/04 11:45:31, aandrey ...
7 years ago (2013-12-04 16:00:39 UTC) #7
aandrey
https://codereview.chromium.org/102433002/diff/20001/LayoutTests/inspector/console/console-command-copy.html#newcode29 > LayoutTests/inspector/console/console-command-copy.html:29: > InspectorTest.completeTest(); > On 2013/12/04 11:48:56, pfeldman wrote: > > Just place ...
7 years ago (2013-12-04 16:06:58 UTC) #8
aandrey
7 years ago (2013-12-04 16:07:19 UTC) #9
Dmitry Zvorygin
Fixed comments. Please take a look again.
7 years ago (2013-12-04 17:48:56 UTC) #10
pfeldman
https://codereview.chromium.org/102433002/diff/60001/LayoutTests/http/tests/inspector/inspector-test.js File LayoutTests/http/tests/inspector/inspector-test.js (right): https://codereview.chromium.org/102433002/diff/60001/LayoutTests/http/tests/inspector/inspector-test.js#newcode58 LayoutTests/http/tests/inspector/inspector-test.js:58: InspectorTest.addConsoleSniffer(sniffer); You can't add a sniffer from within sniffer ...
7 years ago (2013-12-05 17:29:54 UTC) #11
Dmitry Zvorygin
Please take a look again.
7 years ago (2013-12-06 11:05:58 UTC) #12
aandrey
https://codereview.chromium.org/102433002/diff/80001/LayoutTests/inspector/console/console-command-copy.html File LayoutTests/inspector/console/console-command-copy.html (right): https://codereview.chromium.org/102433002/diff/80001/LayoutTests/inspector/console/console-command-copy.html#newcode33 LayoutTests/inspector/console/console-command-copy.html:33: RuntimeAgent.evaluate("copy(null)", "", true, InspectorTest.completeTest.bind(InspectorTest)); wrong indent
7 years ago (2013-12-06 11:08:01 UTC) #13
Dmitry Zvorygin
Fixed indentation. https://codereview.chromium.org/102433002/diff/80001/LayoutTests/inspector/console/console-command-copy.html File LayoutTests/inspector/console/console-command-copy.html (right): https://codereview.chromium.org/102433002/diff/80001/LayoutTests/inspector/console/console-command-copy.html#newcode33 LayoutTests/inspector/console/console-command-copy.html:33: RuntimeAgent.evaluate("copy(null)", "", true, InspectorTest.completeTest.bind(InspectorTest)); On 2013/12/06 11:08:01, ...
7 years ago (2013-12-06 11:28:27 UTC) #14
pfeldman
lgtm
7 years ago (2013-12-06 12:32:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zvorygin@chromium.org/102433002/100001
7 years ago (2013-12-06 12:52:30 UTC) #16
commit-bot: I haz the power
7 years ago (2013-12-06 14:10:18 UTC) #17
Message was sent while issue was closed. 
Change committed as 163344

Powered by Google App Engine
This is Rietveld 408576698