Remove ResourceFetcher's access to a real FetchContext at frame detach time

Remove ResourceFetcher's access to a real FetchContext at frame detach time

This allows us to remove a whole bunch of frame() null-checks in FrameFetchContext.

BUG=458222
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192380

[Nate Chapin, 2015-03-20 23:37:45]

japhet@chromium.org changed reviewers:
+ mkwst@chromium.org, sigbjornf@opera.com

[Nate Chapin, 2015-03-20 23:37:46]

Trying again. Apparently do to quirks of the commit queue implementation, it
didn't notice that I had modified FrameFetchContext.h, and I didn't notice that
a different patch had introduced a new usage of document(), which I removed.

Sigh.

[sof, 2015-03-21 07:23:23]

lgtm

[Mike West, 2015-03-21 12:23:55]

LGTM too.

[Nate Chapin, 2015-03-23 16:46:18]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2015-03-23 16:46:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1024263002/1

[commit-bot: I haz the power, 2015-03-23 16:59:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-23 16:59:19]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)

[Nate Chapin, 2015-03-23 17:37:48]

The CQ bit was checked by japhet@chromium.org

[Nate Chapin, 2015-03-23 17:37:48]

The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com,
mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1024263002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-03-23 17:38:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1024263002/20001

[commit-bot: I haz the power, 2015-03-23 19:14:10]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192380

[sof, 2015-03-24 09:52:10]

Please do go through test results before landing, as this has not happened
afaict each time this CL has been attempted landed.

i.e., htmlimports/import-async-previous.html is still crashing here --


https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/...

[João Eiras, 2015-03-24 11:58:01]

joaoe@opera.com changed reviewers:
+ joaoe@opera.com

[João Eiras, 2015-03-24 11:58:02]

https://codereview.chromium.org/1024263002/diff/20001/Source/core/loader/Fram...
File Source/core/loader/FrameFetchContext.cpp (right):

https://codereview.chromium.org/1024263002/diff/20001/Source/core/loader/Fram...
Source/core/loader/FrameFetchContext.cpp:609: if
(!RuntimeEnabledFeatures::clientHintsEnabled() || !m_document)
Wouldn't it make sense to use frame()->document() here ?

https://codereview.chromium.org/1024263002/diff/20001/Source/core/loader/Fram...
Source/core/loader/FrameFetchContext.cpp:622: if (!m_document)
Wouldn't it make sense to use frame()->document() here ?

[alph, 2015-03-24 17:25:45]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1012633004/ by alph@chromium.org.

The reason for reverting is: Suspect it responsible for
http/tests/htmlimports/import-async-previous.html crashing

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=htt...
.