Issue 1024243003: Turn down warning level for GN build of image_diff utility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1024243003: Turn down warning level for GN build of image_diff utility (Closed)

Created:
5 years, 9 months ago by Tom Sepez

Modified:
5 years, 9 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Turn down warning level for GN build of image_diff utility Next attempt to get GN build to work. Once this lands, doing a DEPS roll against the win8_chromium_gn_dbg trybot seems to catch the issue. Restore image_diff_png.cc to its previous state. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/7b4c0028550c32b0b773368ff4bbcc1d1adcd928

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	samples/BUILD.gn	View		1 chunk	+5 lines, -1 line	0 comments	Download
	M	samples/image_diff_png.cc	View		3 chunks	+10 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Tom Sepez

5 years, 9 months ago (2015-03-21 00:09:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7b4c0028550c32b0b773368ff4bbcc1d1adcd928 (tree was closed).