Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: Source/core/dom/CompositorProxy.h

Issue 1024233002: compositor-worker: Introduce CompositorProxy. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: . Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CompositorProxy_h
6 #define CompositorProxy_h
7
8 #include "bindings/core/v8/ScriptWrappable.h"
9 #include "core/dom/Element.h"
10 #include "platform/heap/Handle.h"
11 #include "wtf/PassOwnPtr.h"
12 #include "wtf/PassRefPtr.h"
13 #include "wtf/RefCounted.h"
14 #include "wtf/text/WTFString.h"
15
16 namespace blink {
17
18 class ExceptionState;
19 class ExecutionContext;
20
21 class CompositorProxy : public GarbageCollectedFinalized<CompositorProxy>, publi c ScriptWrappable {
esprehn 2015/03/25 23:21:48 final
sadrul 2015/03/27 17:23:28 Done.
22 DEFINE_WRAPPERTYPEINFO();
23 public:
24 static CompositorProxy* create(ExecutionContext*, Element*, Vector<String>& attributeArray, ExceptionState&);
25 static CompositorProxy* create(uint64_t element, uint32_t attributeFlags);
26 virtual ~CompositorProxy();
27
28 enum class Attributes {
29 NONE = 0x0000,
30 OPACITY = 0x0001,
31 SCROLL_TOP = 0x0002,
32 TOUCH = 0x0004,
33 TRANSFORM = 0x0008,
esprehn 2015/03/25 23:21:48 1 << 1, 1 << 2, is preferred in blink.
sadrul 2015/03/27 17:23:28 Done.
34 };
35
36 DEFINE_INLINE_TRACE() { }
37
38 uint64_t elementId() const { return m_elementId; }
39 uint32_t attributes() const { return m_attributes; }
esprehn 2015/03/25 23:21:48 Can this be a bitfield instead?
sadrul 2015/03/27 17:23:28 I am not entirely sure I understand. Do you mean s
sadrul 2015/03/27 18:14:56 I have gone ahead and made this change. PTAL.
40
41 protected:
42 CompositorProxy(Element*, uint32_t attributeFlags);
esprehn 2015/03/25 23:21:48 reference
sadrul 2015/03/27 17:23:29 Done.
43 CompositorProxy(uint64_t element, uint32_t attributeFlags);
44
45 private:
46 const uint64_t m_elementId;
47 uint32_t m_attributes;
esprehn 2015/03/25 23:21:48 const? Attributes doesn't seem to be able to chang
sadrul 2015/03/27 17:23:29 Done.
48 };
49
50 } // namespace blink
51
52 #endif // CompositorProxy_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698