chrome/browser/sync/glue/frontend_data_type_controller.h - Issue 1024223002: [Sync] Split model association into multiple UI tasks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/frontend_data_type_controller.h

Issue 1024223002: [Sync] Split model association into multiple UI tasks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc ('k') | chrome/browser/sync/glue/frontend_data_type_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/frontend_data_type_controller.h

diff --git a/chrome/browser/sync/glue/frontend_data_type_controller.h b/chrome/browser/sync/glue/frontend_data_type_controller.h

index b5ffd6e1d453b0efd8c2da184eb9fad2cc9575e7..032385986175bd102878f9e13d05b63a9c33e820 100644

--- a/chrome/browser/sync/glue/frontend_data_type_controller.h

+++ b/chrome/browser/sync/glue/frontend_data_type_controller.h

@@ -129,11 +129,7 @@ class FrontendDataTypeController : public sync_driver::DataTypeController {

private:

// Build sync components and associate models.

- // Return value:

- // True - if association was successful. FinishStart should have been

- // invoked.

- // False - if association failed. StartFailed should have been invoked.

- virtual bool Associate();

+ virtual void Associate();

void AbortModelLoad();