Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1024203004: Port LTO-related flags to more platforms. (Closed)

Created:
5 years, 9 months ago by pcc1
Modified:
5 years, 9 months ago
Reviewers:
Nico, pcc
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Port LTO-related flags to more platforms. Specifically: - Supply -function-sections flag to the gold plugin when targeting ARM. Without this flag, LTO can produce a .text section that is larger than the maximum call displacement, preventing the linker from relocating calls. - Move the other gold plugin-specific flag to the same place, and add a Mac version. BUG=469376, 469377 R=thakis@chromium.org Committed: https://crrev.com/99ee00d89b2ecfc70682d3222014839adfbceab8 Cr-Commit-Position: refs/heads/master@{#321841}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add link to LLVM bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -6 lines) Patch
M build/common.gypi View 1 2 chunks +35 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
pcc1
5 years, 9 months ago (2015-03-21 01:35:44 UTC) #1
Nico
lgtm https://codereview.chromium.org/1024203004/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/1024203004/diff/1/build/common.gypi#newcode5964 build/common.gypi:5964: # than the maximum call displacement, preventing the ...
5 years, 9 months ago (2015-03-21 03:48:24 UTC) #2
pcc
https://codereview.chromium.org/1024203004/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/1024203004/diff/1/build/common.gypi#newcode5964 build/common.gypi:5964: # than the maximum call displacement, preventing the linker ...
5 years, 9 months ago (2015-03-23 18:17:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024203004/20001
5 years, 9 months ago (2015-03-23 18:18:18 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-23 20:50:05 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 20:51:28 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/99ee00d89b2ecfc70682d3222014839adfbceab8
Cr-Commit-Position: refs/heads/master@{#321841}

Powered by Google App Engine
This is Rietveld 408576698