Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1024183004: Fix chrome_elf_unittests to handle dlls being blacklisted before the tests start (Closed)

Created:
5 years, 9 months ago by csharp
Modified:
5 years, 8 months ago
Reviewers:
robertshield
CC:
chromium-reviews, caitkp+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix chrome_elf_unittests to handle dlls being blacklisted before the tests start BUG=463495, 463500 Committed: https://crrev.com/608475f1d391f9fe61645952a87d185dd83a5c55 Cr-Commit-Position: refs/heads/master@{#322878}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Responding to comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -95 lines) Patch
M chrome_elf/blacklist/blacklist.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_elf/blacklist/test/blacklist_test.cc View 1 6 chunks +102 lines, -93 lines 0 comments Download
M chrome_elf/blacklist/test/blacklist_test_main_dll.def View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
csharp
5 years, 9 months ago (2015-03-20 20:54:25 UTC) #2
robertshield
lg, one question, one nit https://codereview.chromium.org/1024183004/diff/1/chrome_elf/blacklist/test/blacklist_test.cc File chrome_elf/blacklist/test/blacklist_test.cc (right): https://codereview.chromium.org/1024183004/diff/1/chrome_elf/blacklist/test/blacklist_test.cc#newcode60 chrome_elf/blacklist/test/blacklist_test.cc:60: // http://crbug.com/397137 Is this ...
5 years, 9 months ago (2015-03-23 03:59:28 UTC) #3
csharp
https://codereview.chromium.org/1024183004/diff/1/chrome_elf/blacklist/test/blacklist_test.cc File chrome_elf/blacklist/test/blacklist_test.cc (right): https://codereview.chromium.org/1024183004/diff/1/chrome_elf/blacklist/test/blacklist_test.cc#newcode60 chrome_elf/blacklist/test/blacklist_test.cc:60: // http://crbug.com/397137 On 2015/03/23 03:59:28, robertshield wrote: > Is ...
5 years, 9 months ago (2015-03-23 17:17:18 UTC) #4
csharp
ping
5 years, 8 months ago (2015-03-30 17:29:12 UTC) #5
robertshield
lgtm
5 years, 8 months ago (2015-03-30 20:25:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024183004/20001
5 years, 8 months ago (2015-03-30 20:26:59 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-03-30 21:43:55 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 21:44:36 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/608475f1d391f9fe61645952a87d185dd83a5c55
Cr-Commit-Position: refs/heads/master@{#322878}

Powered by Google App Engine
This is Rietveld 408576698