Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: media/cast/rtcp/rtcp_sender.h

Issue 102413014: Cast:Splitting rtcp sender (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/rtcp/rtcp_receiver_unittest.cc ('k') | media/cast/rtcp/rtcp_sender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/rtcp/rtcp_sender.h
diff --git a/media/cast/rtcp/rtcp_sender.h b/media/cast/rtcp/rtcp_sender.h
index e931c693c0ff3c04c9b2bd7ae1f6c7a4ed8ac88b..310f6da3413a8ba140c41c07385052503fb12d5e 100644
--- a/media/cast/rtcp/rtcp_sender.h
+++ b/media/cast/rtcp/rtcp_sender.h
@@ -16,6 +16,7 @@
namespace media {
namespace cast {
+// TODO(mikhal): Resolve duplication between this and RtcpBuilder.
class RtcpSender {
public:
RtcpSender(scoped_refptr<CastEnvironment> cast_environment,
@@ -25,11 +26,6 @@ class RtcpSender {
virtual ~RtcpSender();
- void SendRtcpFromRtpSender(uint32 packet_type_flags,
- const RtcpSenderInfo* sender_info,
- const RtcpDlrrReportBlock* dlrr,
- RtcpSenderLogMessage* sender_log);
-
void SendRtcpFromRtpReceiver(uint32 packet_type_flags,
const RtcpReportBlock* report_block,
const RtcpReceiverReferenceTimeReport* rrtr,
@@ -54,10 +50,6 @@ class RtcpSender {
};
private:
- void BuildSR(const RtcpSenderInfo& sender_info,
- const RtcpReportBlock* report_block,
- std::vector<uint8>* packet) const;
-
void BuildRR(const RtcpReportBlock* report_block,
std::vector<uint8>* packet) const;
@@ -80,18 +72,12 @@ class RtcpSender {
void BuildBye(std::vector<uint8>* packet) const;
- void BuildDlrrRb(const RtcpDlrrReportBlock* dlrr,
- std::vector<uint8>* packet) const;
-
void BuildRrtr(const RtcpReceiverReferenceTimeReport* rrtr,
std::vector<uint8>* packet) const;
void BuildCast(const RtcpCastMessage* cast_message,
std::vector<uint8>* packet) const;
- void BuildSenderLog(RtcpSenderLogMessage* sender_log_message,
- std::vector<uint8>* packet) const;
-
void BuildReceiverLog(RtcpReceiverLogMessage* receiver_log_message,
std::vector<uint8>* packet) const;
« no previous file with comments | « media/cast/rtcp/rtcp_receiver_unittest.cc ('k') | media/cast/rtcp/rtcp_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698